fix: require firebase/php-jwt in core and all apps can use it#40901
Merged
phil-davis merged 2 commits intomasterfrom Aug 3, 2023
Merged
fix: require firebase/php-jwt in core and all apps can use it#40901phil-davis merged 2 commits intomasterfrom
firebase/php-jwt in core and all apps can use it#40901phil-davis merged 2 commits intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
firebase/php-jwt in core and all apps can use it
Contributor
|
Do we have backwards compat issues to keep in mind? |
Contributor
yes - https://github.com/owncloud/wopi/pull/254#issuecomment-1663752003 |
Member
Author
|
will take care ... |
4ececd0 to
92de25d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
version on texteditor and wopi was been adjusted |
phil-davis
approved these changes
Aug 3, 2023
Contributor
|
Merged so that this will get into the core daily tarball tonight. Then the fles_texteditor and wopi CI will run with that core, and we will see what happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Sort out dependency hell for
firebase/php-jwtRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: