Skip to content

docs: clarify missing wnd config parameter#41106

Merged
mmattel merged 2 commits intomasterfrom
wnd_fix_for_config_apps_sample
Nov 16, 2023
Merged

docs: clarify missing wnd config parameter#41106
mmattel merged 2 commits intomasterfrom
wnd_fix_for_config_apps_sample

Conversation

@mmattel
Copy link
Copy Markdown
Contributor

@mmattel mmattel commented Nov 16, 2023

One WND config parameter needs clarification - this was missing.

@update-docs
Copy link
Copy Markdown

update-docs bot commented Nov 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

* "user001@my.dom.com" will be mapped to the same windows user as
* "user001@not.mine.eu".
*
* - `CustomFile`: This mapping is reserved and should only be used on explicit request of ownCloud support.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go further to say that it isn't implemented and there is no short term plan to add it.
Right now, it seems that there is a "magic button" to enable the mapping, but it isn't the case. It could take some time to implement the mapping, which might not be what the admin expects.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is as you described in the referenced wnd comment, that you want to keep it as reminder. If we write not implemented, than we need to remove it completely as this does not makes sense. To get a diplomatic balance between the two positions, I decided to write this, which is a dont do this and if you do you are on your own if stuff breakes.

This comment was marked as outdated.

@mmattel mmattel merged commit b7c903c into master Nov 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the wnd_fix_for_config_apps_sample branch November 16, 2023 09:32
jnweiger

This comment was marked as outdated.

@DeepDiver1975
Copy link
Copy Markdown
Member

@jnweiger please apply a bit more care next time before merging - there is absolutely no need in having 3 commits now on master for this change. This should have been squashed

Look how ugly this looks like ....
Screenshot from 2023-11-16 10-37-58

jnweiger pushed a commit that referenced this pull request Nov 17, 2023
jnweiger added a commit that referenced this pull request Nov 17, 2023
* Merge pull request #41104 from owncloud/update_config_apps_sample

docs: add missing WND Kerberos settings to config.apps.sample

* Merge pull request #41106 from owncloud/wnd_fix_for_config_apps_sample

docs: clarify missing wnd config parameter

---------

Co-authored-by: Martin <github@diemattels.at>
phil-davis pushed a commit that referenced this pull request Nov 22, 2023
* Merge pull request #41104 from owncloud/update_config_apps_sample

docs: add missing WND Kerberos settings to config.apps.sample

* Merge pull request #41106 from owncloud/wnd_fix_for_config_apps_sample

docs: clarify missing wnd config parameter

---------

Co-authored-by: Martin <github@diemattels.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants