Skip to content

refactor: set id for oc_file_locks to bigint#41158

Merged
DeepDiver1975 merged 2 commits intomasterfrom
change_file_locks_id_to_bigint
Jan 22, 2024
Merged

refactor: set id for oc_file_locks to bigint#41158
DeepDiver1975 merged 2 commits intomasterfrom
change_file_locks_id_to_bigint

Conversation

@pako81
Copy link
Copy Markdown

@pako81 pako81 commented Jan 12, 2024

Description

Set the id column for the oc_file_locks table to bigint

Related Issue

Motivation and Context

In rare cases, the id column in the file_locks table could hit its limit (currently defined as int(10) unsigned) as it is set as autoincrement.

How Has This Been Tested?

  • Manually, by running occ upgrade or occ migrations:execute core 20240112140951 and be sure the id column is set to bigint(20) unsigned

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 added this to the development milestone Jan 12, 2024
@pako81 pako81 self-assigned this Jan 12, 2024
@update-docs
Copy link
Copy Markdown

update-docs bot commented Jan 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pako81 pako81 changed the title refactor: set id for file_locks to bigint refactor: set id for oc_file_locks to bigint Jan 12, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 53%)

See analysis details on SonarCloud

@pako81
Copy link
Copy Markdown
Author

pako81 commented Jan 19, 2024

@DeepDiver1975 @jvillafanez what do we want to do here?

@pako81
Copy link
Copy Markdown
Author

pako81 commented Jan 22, 2024

should we merge this despite SonarCloud complaining? It is about tabs to be replaced by blank spaces but already did it, so not sure why it is still complaining..

@DeepDiver1975
Copy link
Copy Markdown
Member

should we merge this despite SonarCloud complaining? It is about tabs to be replaced by blank spaces but already did it, so not sure why it is still complaining..

sonar is complaining about test coverage. This can be ignored as we have no way to unit test migrations ... directly ...

@DeepDiver1975 DeepDiver1975 merged commit 17d8d94 into master Jan 22, 2024
@delete-merged-branch delete-merged-branch bot deleted the change_file_locks_id_to_bigint branch January 22, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants