refactor: set id for oc_file_locks to bigint#41158
Merged
DeepDiver1975 merged 2 commits intomasterfrom Jan 22, 2024
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Author
|
@DeepDiver1975 @jvillafanez what do we want to do here? |
jvillafanez
approved these changes
Jan 22, 2024
Author
|
should we merge this despite SonarCloud complaining? It is about tabs to be replaced by blank spaces but already did it, so not sure why it is still complaining.. |
Member
sonar is complaining about test coverage. This can be ignored as we have no way to unit test migrations ... directly ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Set the id column for the
oc_file_lockstable to bigintRelated Issue
Motivation and Context
In rare cases, the id column in the
file_lockstable could hit its limit (currently defined asint(10) unsigned) as it is set as autoincrement.How Has This Been Tested?
occ upgradeorocc migrations:execute core 20240112140951and be sure the id column is set tobigint(20) unsignedTypes of changes
Checklist: