fix: change default value of preview_max_dimensions to 6016x6016#41263
fix: change default value of preview_max_dimensions to 6016x6016#41263DeepDiver1975 merged 1 commit intomasterfrom
preview_max_dimensions to 6016x6016#41263Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Changelog? I guess there should be something, because there has been a bit of discussion about this stuff. So it would be nice if the changelog at each release point shows clearly what the default setting is at each release. |
|
will add changelog item |
DeepDiver1975
force-pushed
the
fix/preview_max_dimensions
branch
from
7e844eb to
f545470
Compare
|
|
Related #41193 |
| private function getMaxDimensions(): array { | ||
| // 24 MP - 6016 x 4000 | ||
| $maxDimension = \OC::$server->getConfig()->getSystemValue('preview_max_dimensions', '6016x4000'); | ||
| // 24 MP - 6016 x 6016 |
There was a problem hiding this comment.
Should it not be 36 MP? But since it is just a comment, maybe not that relevant..
There was a problem hiding this comment.
24 mega pixel is 6k x 4k - allowing it in portrait and landscape mode results in 6k x 6k
There was a problem hiding this comment.
I think this is okay this way ..... or is more explanation required here?
4 participants
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: