feat: accept 2 characters Chinese/Japanese input to perform search action#41328
Merged
DeepDiver1975 merged 1 commit intoowncloud:masterfrom Nov 8, 2024
Merged
feat: accept 2 characters Chinese/Japanese input to perform search action#41328DeepDiver1975 merged 1 commit intoowncloud:masterfrom
DeepDiver1975 merged 1 commit intoowncloud:masterfrom
Conversation
… action As some user mentioned years ago about not able to perform search with Chineses/Japanese characters with less than 3 characters query input, it turns out that there is the hard limit in the front end code that requires minimum 3 characters input to perform the query on the server side, otherwise it only query in the front-end within the current folder displayed. Since the Chinese/Japanese words are more "condense" with their meanings, it is so common for their users to search with 2 words so with the word splitting mechanism used by search engines such as elastic search. So if we decrease the characters limit only for the Chinese/Japanese characters, it would not impact the server performance as some 2 characters English words would cause like "to", "go", "am" ext. And it is pretty easy to distinguish the Chinese/Japanese words only using the string match function on their encoding sequence which are adjacent. It would make the search experience a lot better for Chinese/Japanese users.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
|
Member
|
oh damn it - we require a changelog 🙈 @timeswind mind opening another pr to add the changelog item? THX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As some user mentioned years ago #25021, #9916 about not able to perform search with Chineses/Japanese characters with less than 3 characters query input, it turns out that there is the hard limit in the front end code that requires minimum 3 characters input to perform the query on the server side, otherwise it only query in the front-end within the current folder displayed.
Since the Chinese/Japanese words are more "condense" with their meanings, it is so common for their users to search with 2 words so with the word splitting mechanism used by search engines such as elastic search. So if we decrease the characters limit only for the Chinese/Japanese characters, it would not impact the server performance as some 2 characters English words would cause like "to", "go", "am" ext. And it is pretty easy to distinguish the Chinese/Japanese words only using the string match function on their encoding sequence which are adjacent.
Related Issue
Motivation and Context
make the search experience a lot better for Chinese/Japanese users
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: