fix: web updater is now disabled by default + discourage users to use the web updater

[DeepDiver1975]

Description

The web updater is a relic of old times and can cause more trouble than help.
More details on #41149

Related Issue

• Fixes Suggestion: Disable (Web-)Updater by default. #41149

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[jvillafanez]

I'll probably need some additional context...

If we want to just disable the web updater, adding a migration to set the web-updater.enabled config to false should be enough. However, it seems we're doing more than that.

I assume we don't want people to run the web-updater.
What is the behavior when the web-updater is disabled? I guess it will just show a message telling people that a new version is available. However, what if it's enabled? What is the difference between having the web-updater enabled or disabled?

[jvillafanez]

core/apps/updatenotification/appinfo/routes.php

Line 27 in d25de58

['name' => 'Admin#createCredentials', 'url' => '/credentials', 'verb' => 'GET'],

should also be removed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud