Implement batch action for inviting users to groups#522
Merged
DeepDiver1975 merged 2 commits intofeat/invite-guestsfrom Jul 18, 2022
Merged
Implement batch action for inviting users to groups#522DeepDiver1975 merged 2 commits intofeat/invite-guestsfrom
DeepDiver1975 merged 2 commits intofeat/invite-guestsfrom
Conversation
a56d1c0 to
28d8f7d
Compare
88c7a35 to
6458fb0
Compare
c148b82 to
b5cbf52
Compare
6458fb0 to
d0e327f
Compare
4d9c6ab to
809d8f0
Compare
d0e327f to
cdc39cf
Compare
809d8f0 to
937c755
Compare
Contributor
Author
Contributor
|
I put this into the Classic Server Team Board project, and mentioned some people for review. 1 JS test failed - I have no idea if that is a real fail. There is a conflict reported, so that n eeds to be sorted out. |
jvillafanez
reviewed
Jul 13, 2022
| continue; | ||
| } | ||
|
|
||
| // only add new users |
Member
There was a problem hiding this comment.
it might be better to use a set instead of an array. The operation should be more clear too:
var s = new Set()
s.add(user) // guarantees uniqueness
Contributor
Author
There was a problem hiding this comment.
I tried it, unfortunately Sets do not support uniqueness with objects.
| var user = users[i].trim(); | ||
| var userAdded = false; | ||
|
|
||
| for (var j = 0; j < foundUsers.length; j++) { |
Member
There was a problem hiding this comment.
same as above, it seems better to use a set instead of an array
3c6b2c8 to
f4e8ae5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
Jul 18, 2022
This was referenced Aug 18, 2022
Closed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Works towards https://github.com/owncloud/enterprise/issues/2865