Document the public-files WebDAV API endpoint#1879
Merged
Conversation
settermjd
added
work in progress
This relates to owncloud/core/pull/35932 and #1871.
settermjd
force-pushed
the
document-public-files-webdav-api
branch
from
e3501dc to
0660804
Compare
Contributor
Author
|
@DeepDiver1975, can you review, pls? |
settermjd
added
review required
waiting on feedback
and removed
work in progress
settermjd
changed the title
Contributor
Author
|
ping, @DeepDiver1975. |
DeepDiver1975
requested changes
Oct 9, 2019
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
- request with password is missing - basic auth header with public:${share-password}
Contributor
Author
Thanks for calling that out. Will fix it. |
Contributor
Author
Which example are you referring to? Both the curl and PHP request examples submit auth headers. |
modules/developer_manual/examples/core/scripts/curl/dav/public_files/view_public_link.sh
Outdated
Show resolved
Hide resolved
DeepDiver1975
requested changes
Oct 9, 2019
modules/developer_manual/examples/core/scripts/php/dav/public_files/view_public_link.php
Outdated
Show resolved
Hide resolved
These are added as per @deepdiver's comments https://github.com/owncloud/docs/pull/1879/files#r332913897. An admonition's been added to document how to access the public links when they are password protected.
Contributor
Author
|
@DeepDiver1975, both points of feedback have been addressed. |
DeepDiver1975
requested changes
Oct 9, 2019
modules/developer_manual/examples/core/scripts/curl/dav/public_files/view_public_link.sh
Outdated
Show resolved
Hide resolved
modules/developer_manual/examples/core/scripts/curl/dav/public_files/view_public_link.sh
Outdated
Show resolved
Hide resolved
…d/docs into document-public-files-webdav-api
settermjd
force-pushed
the
document-public-files-webdav-api
branch
from
1f16497 to
1664cae
Compare
Contributor
Author
|
Latest changes implemented. |
settermjd
added a commit
that referenced
this pull request
Oct 10, 2019
settermjd
added a commit
that referenced
this pull request
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to owncloud/core/pull/35932 and #1871.