This repository was archived by the owner on Jan 3, 2024. It is now read-only.
Adds new tab component tabbed including child components, for #535#539
Merged
Adds new tab component tabbed including child components, for #535#539
Conversation
Contributor
|
@marcus-herrmann can you test the component in Phoenix here: https://github.com/owncloud/phoenix/blob/master/apps/files/src/components/FileDetails.vue#L31 |
Contributor
|
code looks fine, as discussed. please submit a PR in Phoenix that works with this PR here, this will confirm that the new tabbed component can work "on the field" |
marcus-herrmann
force-pushed
the
feature/a11y-documentation/tab
branch
5 times, most recently
from
b75d520 to
1e84896
Compare
marcus-herrmann
force-pushed
the
feature/a11y-documentation/tab
branch
from
1e84896 to
8431cce
Compare
4 tasks
| this.changeTab(e.target.id) | ||
| }, | ||
| keydownHandler: function(e) { | ||
| const activeElem = this.$refs.tablist.querySelector(`#${this.activeTab}`) |
Member
There was a problem hiding this comment.
using query selector feels do un-vuejs-ish ... this is what vuejs has refs for ..... or am I missing anything?
Contributor
Author
There was a problem hiding this comment.
I can't really use a ref here since the name is dynamic, I think
Contributor
There was a problem hiding this comment.
indeed, seems not possible. refs are limited to the current component: https://stackoverflow.com/a/42814625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establishes:
oc-tabbedoc-tabbed-taboc-tabbed-panelStructure according to the briefing by @PVince81
Keyboard behaviour, ARIA roles, properties and states according to the Authoring Practice
Intention for establishing new components: Trying to avoid to break phoenix by using the
oc-tab-itemnamespace since the new component is much more complex than the existing one.