Skip to content

Feature/private link#1264

Merged
DeepDiver1975 merged 4 commits intomasterfrom
feature/private-link
Jul 17, 2019
Merged

Feature/private link#1264
DeepDiver1975 merged 4 commits intomasterfrom
feature/private-link

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 commented Jun 6, 2019 •
edited
Loading

Description

The private link to a file can be taken from the side bar now.
Requires owncloud/core#35819

ToDo

  • implement redirect in owncloud 10 to phoenix
  • implement translation from private link with fileid to local user specific path
  • in case of files move into the folder and scroll to the file

How Has This Been Tested?

  • ✋

Screenshots (if appropriate):

The link is copied to the clipboard ...
Screenshot from 2019-06-06 16-39-41

ownCloud server redirects to phoenix/index.html#/f/123456 ...
phoenix resolves fileid to the real path
Screenshot from 2019-07-12 17-17-56

parent folder is loaded, file is highlighted, side bar is being opened and the list is scolled to the item
Screenshot from 2019-07-16 11-22-16

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Jun 6, 2019
@DeepDiver1975 DeepDiver1975 requested a review from LukasHirt June 6, 2019 14:46
@DeepDiver1975 DeepDiver1975 self-assigned this Jun 6, 2019
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

20190606-145121-731.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

20190606-145050-896.png
20190606-145114-532.png
20190606-145138-517.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUISharingInternalGroups failed. Please find the screenshots inside ...

20190606-145209-789.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUIFavorites failed. Please find the screenshots inside ...

20190606-145106-657.png
20190606-145128-152.png
20190606-145148-552.png
20190606-145210-838.png
20190606-145233-439.png
20190606-145256-343.png
20190606-145317-801.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

20190606-145128-202.png
20190606-145148-681.png
20190606-145208-158.png
20190606-145227-881.png
20190606-145247-163.png
20190606-145306-468.png
20190606-145326-097.png
20190606-145345-524.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUIUpload failed. Please find the screenshots inside ...

20190606-145138-866.png
20190606-145203-332.png
20190606-145224-012.png
20190606-145245-776.png
20190606-145307-747.png
20190606-145332-610.png
20190606-145355-502.png
20190606-145418-287.png
20190606-145442-993.png
20190606-145508-374.png
20190606-145532-743.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

20190606-145124-524.png
20190606-145147-330.png
20190606-145210-583.png
20190606-145231-436.png
20190606-145251-945.png
20190606-145313-353.png
20190606-145333-680.png
20190606-145354-097.png
20190606-145415-087.png
20190606-145436-598.png
20190606-145457-949.png
20190606-145519-394.png
20190606-145542-490.png
20190606-145605-338.png
20190606-145627-791.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 6, 2019

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

20190606-145049-383.png
20190606-145108-892.png
20190606-145128-596.png
20190606-145148-049.png
20190606-145208-032.png
20190606-145228-065.png
20190606-145247-470.png
20190606-145307-248.png
20190606-145326-226.png
20190606-145344-734.png
20190606-145403-926.png
20190606-145423-413.png
20190606-145442-801.png
20190606-145501-706.png
20190606-145520-368.png
20190606-145539-221.png
20190606-145558-572.png
20190606-145618-136.png
20190606-145637-112.png
20190606-145656-564.png
20190606-145718-962.png
20190606-145741-438.png
20190606-145804-101.png
20190606-145827-440.png
20190606-145850-683.png
20190606-145913-657.png
20190606-145936-353.png

@DeepDiver1975
Copy link
Copy Markdown
Member Author

DeepDiver1975 commented Jun 7, 2019

we need to handle this differently -> closing

@DeepDiver1975 DeepDiver1975 deleted the feature/private-link branch June 7, 2019 09:07
@DeepDiver1975 DeepDiver1975 restored the feature/private-link branch July 12, 2019 07:55
@DeepDiver1975 DeepDiver1975 reopened this Jul 12, 2019
@DeepDiver1975 DeepDiver1975 force-pushed the feature/private-link branch from 1a93597 to 82e90b5 Compare July 12, 2019 08:03
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/4

20190712-080720-956.png
20190712-080735-247.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUINotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/5

20190712-080827-046.png
20190712-080847-130.png
20190712-080907-265.png
20190712-080927-190.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUISharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/8

20190712-080823-362.png
20190712-080844-820.png
20190712-080906-794.png
20190712-080930-140.png
20190712-080953-635.png
20190712-081016-082.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUIUpload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/11

20190712-080756-466.png
20190712-080813-309.png
20190712-080830-036.png
20190712-080846-668.png
20190712-080903-232.png
20190712-080919-848.png
20190712-080936-389.png
20190712-080953-060.png
20190712-081009-566.png
20190712-081026-316.png
20190712-081042-955.png
20190712-081109-658.png
20190712-081126-153.png
20190712-081142-908.png
20190712-081159-398.png
20190712-081216-127.png
20190712-081232-907.png
20190712-081249-375.png
20190712-081305-993.png
20190712-081322-478.png
20190712-081339-218.png
20190712-081355-980.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/6

20190712-080719-312.png
20190712-080736-824.png
20190712-080754-244.png
20190712-080811-786.png
20190712-080829-359.png
20190712-080846-625.png
20190712-080903-812.png
20190712-080921-420.png
20190712-080938-923.png
20190712-080956-814.png
20190712-081014-628.png
20190712-081032-521.png
20190712-081049-996.png
20190712-081107-576.png
20190712-081125-219.png
20190712-081143-116.png
20190712-081201-026.png
20190712-081219-130.png
20190712-081236-711.png
20190712-081254-064.png
20190712-081311-739.png
20190712-081329-279.png
20190712-081346-876.png
20190712-081404-172.png
20190712-081421-734.png
20190712-081438-785.png
20190712-081456-027.png
20190712-081513-588.png
20190712-081530-971.png
20190712-081548-601.png
20190712-081605-761.png
20190712-081623-401.png
20190712-081640-525.png
20190712-081657-898.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUIFavorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/2

20190712-081116-129.png
20190712-081135-759.png
20190712-081155-153.png
20190712-081214-529.png
20190712-081233-680.png
20190712-081253-392.png
20190712-081312-697.png
20190712-081331-940.png
20190712-081351-311.png
20190712-081410-400.png
20190712-081429-585.png
20190712-081448-835.png
20190712-081508-226.png
20190712-081527-634.png
20190712-081546-777.png
20190712-081605-983.png
20190712-081624-944.png
20190712-081644-214.png
20190712-081703-418.png
20190712-081722-345.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/9

20190712-081319-638.png
20190712-081349-752.png
20190712-081421-206.png
20190712-081450-752.png
20190712-081521-295.png
20190712-081551-915.png
20190712-081620-894.png
20190712-081648-494.png
20190712-081728-645.png
20190712-081805-070.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/10

20190712-081631-435.png
20190712-081658-125.png
20190712-081724-187.png
20190712-081751-269.png
20190712-081816-378.png
20190712-081841-723.png

@DeepDiver1975 DeepDiver1975 force-pushed the feature/private-link branch from 82e90b5 to 672329d Compare July 12, 2019 08:19
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/7

20190712-081336-093.png
20190712-081401-570.png
20190712-081426-528.png
20190712-081451-413.png
20190712-081515-774.png
20190712-081541-393.png
20190712-081606-850.png
20190712-081631-660.png
20190712-081656-945.png
20190712-081721-747.png
20190712-081745-495.png
20190712-081809-479.png
20190712-081834-334.png
20190712-081859-166.png
20190712-081924-326.png
20190712-081949-188.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4052/10

20190712-082353-129.png
20190712-082401-964.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/13

20190712-080948-680.png
20190712-081007-318.png
20190712-081025-940.png
20190712-081044-166.png
20190712-081102-887.png
20190712-081121-812.png
20190712-081140-506.png
20190712-081159-100.png
20190712-081217-546.png
20190712-081235-890.png
20190712-081254-162.png
20190712-081312-845.png
20190712-081335-943.png
20190712-081359-244.png
20190712-081417-848.png
20190712-081436-338.png
20190712-081454-968.png
20190712-081513-536.png
20190712-081532-311.png
20190712-081550-926.png
20190712-081609-316.png
20190712-081627-482.png
20190712-081645-974.png
20190712-081704-527.png
20190712-081723-404.png
20190712-081741-991.png
20190712-081801-839.png
20190712-081821-701.png
20190712-081842-087.png
20190712-081902-710.png
20190712-081923-742.png
20190712-081944-437.png
20190712-082003-171.png
20190712-082022-161.png
20190712-082040-801.png
20190712-082059-447.png
20190712-082118-363.png
20190712-082137-561.png
20190712-082156-267.png
20190712-082215-253.png
20190712-082234-058.png
20190712-082252-872.png
20190712-082311-950.png
20190712-082330-834.png
20190712-082349-374.png
20190712-082408-508.png
20190712-082427-377.png
20190712-082446-310.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/3

20190712-080719-295.png
20190712-080737-167.png
20190712-080754-623.png
20190712-080812-234.png
20190712-080829-943.png
20190712-080847-693.png
20190712-080905-063.png
20190712-080922-428.png
20190712-080939-890.png
20190712-080957-242.png
20190712-081014-692.png
20190712-081032-269.png
20190712-081049-757.png
20190712-081117-688.png
20190712-081135-646.png
20190712-081153-660.png
20190712-081211-277.png
20190712-081228-641.png
20190712-081246-338.png
20190712-081303-800.png
20190712-081321-308.png
20190712-081338-688.png
20190712-081356-317.png
20190712-081413-900.png
20190712-081431-331.png
20190712-081448-707.png
20190712-081506-256.png
20190712-081523-936.png
20190712-081541-321.png
20190712-081558-822.png
20190712-081626-517.png
20190712-081644-289.png
20190712-081701-998.png
20190712-081719-794.png
20190712-081737-314.png
20190712-081754-877.png
20190712-081812-302.png
20190712-081839-794.png
20190712-081857-269.png
20190712-081914-549.png
20190712-081932-207.png
20190712-081949-827.png
20190712-082010-747.png
20190712-082041-817.png
20190712-082102-557.png
20190712-082123-588.png
20190712-082144-781.png
20190712-082205-767.png
20190712-082226-985.png
20190712-082247-987.png
20190712-082309-075.png
20190712-082329-887.png
20190712-082350-869.png
20190712-082411-733.png
20190712-082432-764.png
20190712-082453-648.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4050/12

20190712-080911-682.png
20190712-080935-283.png
20190712-081008-043.png
20190712-081030-295.png
20190712-081052-683.png
20190712-081115-895.png
20190712-081140-350.png
20190712-081203-926.png
20190712-081226-980.png
20190712-081250-043.png
20190712-081313-282.png
20190712-081336-673.png
20190712-081406-998.png
20190712-081437-718.png
20190712-081500-728.png
20190712-081524-553.png
20190712-081548-306.png
20190712-081612-035.png
20190712-081635-549.png
20190712-081659-297.png
20190712-081722-540.png
20190712-081744-757.png
20190712-081807-289.png
20190712-081831-039.png
20190712-081854-647.png
20190712-081918-126.png
20190712-081941-899.png
20190712-082006-393.png
20190712-082032-960.png
20190712-082058-772.png
20190712-082126-066.png
20190712-082151-736.png
20190712-082215-161.png
20190712-082238-712.png
20190712-082301-953.png
20190712-082325-239.png
20190712-082349-077.png
20190712-082412-644.png
20190712-082435-668.png
20190712-082459-509.png
20190712-082523-559.png
20190712-082547-609.png
20190712-082611-082.png
20190712-082633-654.png
20190712-082656-568.png
20190712-082720-162.png
20190712-082744-381.png
20190712-082807-990.png

This was referenced Jul 12, 2019
Merged
Merged
@DeepDiver1975 DeepDiver1975 force-pushed the feature/private-link branch from 672329d to b4d88cd Compare July 12, 2019 15:22
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 12, 2019

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4074/10

20190712-153906-023.png
20190712-153923-462.png

@DeepDiver1975 DeepDiver1975 force-pushed the feature/private-link branch 4 times, most recently from 35a5f6c to e39015d Compare July 16, 2019 09:35
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 17, 2019
Merged
11 tasks
LukasHirt
LukasHirt approved these changes Jul 17, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Just one thing. If you are not signed in and try to go there, after logging in you're not redirected to the file. But I guess this will come in later iteration so approving now 😉

@DeepDiver1975
Copy link
Copy Markdown
Member Author

DeepDiver1975 commented Jul 17, 2019

But I guess this will come in later iteration so approving now wink

yes - indeed

@DeepDiver1975 DeepDiver1975 force-pushed the feature/private-link branch from e39015d to a0a4bc4 Compare July 17, 2019 10:59
@DeepDiver1975 DeepDiver1975 merged commit 64a0778 into master Jul 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/private-link branch July 17, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels

Status:Needs-Review Needs review from a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @ownclouders @LukasHirt @micbar