Files table virtual scroller#2280

LukasHirt · 2019-10-16T13:40:21Z

Description

Implement virtual scroller into FileList component and adjust layout in affected lists.

Related Issue

Refs Partial loading of file list #116

Motivation and Context

Smooth experience when rendering loaded items.

How Has This Been Tested?

test environment: Manually

Have 10 000 files in one folder and try to load them
Try creating a new file/folder
Try deleting some file/folder

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Test in ie11
Fix layout of table
Implement also in shared with list

apps/files/src/components/FileList.vue

PVince81 · 2019-10-21T13:45:23Z

as discussed, see if this brings us closed to fixed table headers

PVince81 · 2019-10-21T13:52:24Z

also discussed: if we go with a generic file list component or list component as in #2077 (comment), we could integrate virtual scrolling there by default

LukasHirt · 2019-10-21T23:49:09Z

Let's see what tests will say now. If they'll pass I think this PR will be ready for reviews. I still need to test it in IE11 though.

ownclouders · 2019-12-12T12:36:34Z

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7133/

ownclouders · 2019-12-12T12:44:49Z

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7133/

ownclouders · 2019-12-12T12:51:04Z

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7133/

individual-it · 2019-12-13T03:39:00Z

@LukasHirt I will have a look, but do not have time in the next hours. Have a look at this issue #2515 (comment)
that sounds similar, maybe its an ODS related problem

LukasHirt · 2019-12-13T08:55:27Z

that sounds similar, maybe its an ODS related problem

@individual-it I rebased the PR so hopefully, the menu error will be gone. I think it will still fail at the sharing scenario "Auto-accept shares" but as I mentioned, it passes locally so not really sure what to do with that one.

individual-it · 2019-12-13T10:12:16Z

all green, merging?

LukasHirt · 2019-12-13T10:19:49Z

all green, merging?

Can you review the tests pls? @individual-it

individual-it

suggesting to put the custom commands as methods into the pageObjects
and generally lets have selectors defined in the selectors section of the corresponding pageObjects. test-code is code, so we should use good coding practice e.g. #files-list-container is mentioned in multiple places - so DRY :-)

tests/acceptance/customCommands/findItemInFilesList.js

tests/acceptance/features/webUIRenameFolders/renameFolders.feature

tests/acceptance/pageObjects/FilesPageElement/filesList.js

tests/acceptance/customCommands/filesListScrollToTop.js

LukasHirt · 2019-12-13T12:41:19Z

@individual-it Tests have been adjusted 😉

ownclouders · 2019-12-13T13:01:01Z

💥 Acceptance tests SharingAcceptShares failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7169/

LukasHirt · 2019-12-13T13:48:43Z

Damn it. Again broken.

ownclouders · 2019-12-13T13:58:31Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7169/

ownclouders · 2019-12-13T14:51:08Z

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7170/

ownclouders · 2019-12-13T14:56:41Z

💥 Acceptance tests SharingAcceptShares failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7170/

ownclouders · 2019-12-13T15:14:51Z

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7170/

ownclouders · 2019-12-13T15:15:19Z

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7170/

ownclouders · 2019-12-13T15:56:21Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7170/

ownclouders · 2019-12-16T09:13:38Z

💥 Acceptance tests SharingExternal failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7202/

ownclouders · 2019-12-16T09:20:24Z

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7202/

PVince81 · 2019-12-17T09:00:25Z

conflict 🙈

skshetry

Nitpicky: There's just too many empty lines/separation of the block on tests. They are all related, so, any reason to separate those?

individual-it

jut minor issues

tests/acceptance/features/webUIFiles/fileDetails.feature

tests/acceptance/pageObjects/FilesPageElement/filesList.js

Fixed sizes of columns Made responsive Adjusted layout Adjusted shared with list Bring back id for the list Moved virtual scroller into files app dependencies and added polyfill Make table header fixed Use only class selector for file row Added border and selected background colour Scroll files list Fixed file row selector Scroll with interval Moved findFile into custom commands and added wait for filesListContainer Fixed wrong name in private link feature Fixed wrong item type Moved row actions into own component and moved after files list Made functions async and escape double quotes Count files via counters in footer and fixed scrollToTop function Check if the item is actually visible and not only rendered and await click on row for private link Fixed trashbin delete tests Finishing touches for scroll functions and adjusted sharing functions to await scrolling Adjusted resharing tests Adjusted sharing and distance of scrolling Add position of header to get properly visible items Re-enable correct step in shared-with pages tests Bring waitForFileVisible into versions test Fixed mobile view Adjusted order of scroll for opening of sidebar and wait for file in shared with pages Use shareId as default id and get rid of two TODOs Remove unneccesary logs Check if list container is visible in scrollToTop, reorder calls for different scrolling and reuse filename attribute Added isVisible data state Adjusted selector for trashbin Changed selector for actions dropdown Escape double quotes Adjusted dependencies Adjusted filter selectors and label after ods update Fixed order of parameters Create replaceChar function

LukasHirt · 2019-12-17T10:20:11Z

Nitpicky: There's just too many empty lines/separation of the block on tests. They are all related, so, any reason to separate those?

I'm separating pieces of code with new lines to make it more readable.

LukasHirt · 2019-12-17T10:20:36Z

@individual-it Changes implemented.

LukasHirt · 2019-12-17T11:38:09Z

Opened an issue for virtual scroll in trashbin - #2723

LukasHirt added Category:Enhancement Add new functionality Status:In-Progress labels Oct 16, 2019

LukasHirt self-assigned this Oct 16, 2019

LukasHirt changed the title ~~Files table virtual scroller~~ [POCFiles table virtual scroller Oct 16, 2019

LukasHirt changed the title ~~[POCFiles table virtual scroller~~ [POC] Files table virtual scroller Oct 16, 2019

DeepDiver1975 mentioned this pull request Oct 21, 2019

Feature/streamed file list #2299

Closed

10 tasks

LukasHirt force-pushed the feature/virtual-scroller branch from 467ab39 to 444f50a Compare October 21, 2019 10:53

LukasHirt commented Oct 21, 2019

View reviewed changes

apps/files/src/components/FileList.vue Outdated Show resolved Hide resolved

owncloud deleted a comment from ownclouders Oct 21, 2019

LukasHirt force-pushed the feature/virtual-scroller branch from 444f50a to cab3761 Compare October 21, 2019 11:16

LukasHirt force-pushed the feature/virtual-scroller branch from cab3761 to bdb7f32 Compare October 21, 2019 23:45

owncloud deleted a comment from ownclouders Oct 21, 2019

individual-it requested changes Dec 13, 2019

View reviewed changes

LukasHirt mentioned this pull request Dec 13, 2019

breadcrumb is not seen one level below the root directory if rootFolder is set #2538

Closed

skshetry reviewed Dec 17, 2019

View reviewed changes

individual-it requested changes Dec 17, 2019

View reviewed changes

tests/acceptance/features/webUIFiles/fileDetails.feature Outdated Show resolved Hide resolved

tests/acceptance/pageObjects/FilesPageElement/filesList.js Outdated Show resolved Hide resolved

tests/acceptance/pageObjects/FilesPageElement/filesList.js Outdated Show resolved Hide resolved

LukasHirt mentioned this pull request Dec 17, 2019

Implement virtual scroll in trashbin #2723

Closed

individual-it approved these changes Dec 17, 2019

View reviewed changes

individual-it mentioned this pull request Dec 19, 2019

Timeouts async script #2752

Merged

10 tasks

Conversation

LukasHirt commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Open tasks:

Uh oh!

Uh oh!

PVince81 commented Oct 21, 2019

Uh oh!

PVince81 commented Oct 21, 2019

Uh oh!

LukasHirt commented Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ownclouders commented Dec 12, 2019

Uh oh!

ownclouders commented Dec 12, 2019

Uh oh!

ownclouders commented Dec 12, 2019

Uh oh!

individual-it commented Dec 13, 2019

Uh oh!

LukasHirt commented Dec 13, 2019

Uh oh!

individual-it commented Dec 13, 2019

Uh oh!

LukasHirt commented Dec 13, 2019

Uh oh!

individual-it left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasHirt commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

LukasHirt commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 13, 2019

Uh oh!

ownclouders commented Dec 16, 2019

Uh oh!

ownclouders commented Dec 16, 2019

Uh oh!

PVince81 commented Dec 17, 2019

Uh oh!

skshetry left a comment

Choose a reason for hiding this comment

Uh oh!

individual-it left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasHirt commented Dec 17, 2019

Uh oh!

LukasHirt commented Dec 17, 2019

Uh oh!

LukasHirt commented Dec 17, 2019

LukasHirt commented Oct 16, 2019 •

edited

Loading

LukasHirt commented Oct 21, 2019 •

edited

Loading