Skip to content

Feature/implement oc tabbed#2515

Closed
marcus-herrmann wants to merge 1 commit intomasterfrom
feature/implement-oc-tabbed
Closed

Feature/implement oc tabbed#2515
marcus-herrmann wants to merge 1 commit intomasterfrom
feature/implement-oc-tabbed

Conversation

@marcus-herrmann
Copy link
Copy Markdown
Contributor

@marcus-herrmann marcus-herrmann commented Nov 21, 2019

Description

Implements new accessible tab component oc-tabbedfor Files sidebar. Related PR in ODS: owncloud/owncloud-design-system#539

Related Issue

Motivation and Context

See motivation of ODS ticket: Aiming to improve screen reader and keyboard accessibility of tabs in Files Sidebar

Types of changes

Changed FileDetails.vue to match with new tab component DOM

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@marcus-herrmann marcus-herrmann added this to the Milestone 1: Phoenix for users milestone Nov 21, 2019
@marcus-herrmann marcus-herrmann self-assigned this Nov 21, 2019
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests PrivateLinks failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080114-708.png
20191121-080154-753.png
20191121-080230-032.png
20191121-080306-376.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080245-181.png
20191121-080245-413.png
20191121-080342-164.png
20191121-080342-465.png
20191121-080438-410.png
20191121-080438-631.png
20191121-080514-749.png
20191121-080515-008.png
20191121-080611-596.png
20191121-080611-803.png
20191121-080647-439.png
20191121-080647-720.png
20191121-080722-992.png
20191121-080723-258.png
20191121-080758-002.png
20191121-080758-269.png
20191121-080834-454.png
20191121-080834-691.png
20191121-080910-777.png
20191121-080910-989.png
20191121-080946-072.png
20191121-080946-339.png
20191121-081021-696.png
20191121-081022-102.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080023-984.png
20191121-080024-198.png
20191121-080058-531.png
20191121-080058-783.png
20191121-080132-912.png
20191121-080133-105.png
20191121-080206-905.png
20191121-080207-091.png
20191121-080241-137.png
20191121-080241-405.png
20191121-080314-918.png
20191121-080315-164.png
20191121-080351-434.png
20191121-080351-647.png
20191121-080427-623.png
20191121-080427-830.png
20191121-080524-490.png
20191121-080524-743.png
20191121-080601-275.png
20191121-080601-549.png
20191121-080638-309.png
20191121-080638-508.png
20191121-080714-710.png
20191121-080714-934.png
20191121-080748-667.png
20191121-080748-933.png
20191121-080822-459.png
20191121-080822-700.png
20191121-080856-422.png
20191121-080856-628.png
20191121-080931-559.png
20191121-080931-758.png
20191121-081027-517.png
20191121-081027-703.png
20191121-081123-710.png
20191121-081123-897.png
20191121-081218-178.png
20191121-081218-391.png
20191121-081252-532.png
20191121-081252-719.png
20191121-081326-387.png
20191121-081326-601.png
20191121-081400-850.png
20191121-081401-053.png
20191121-081434-798.png
20191121-081435-033.png
20191121-081508-920.png
20191121-081509-154.png
20191121-081543-740.png
20191121-081543-933.png
20191121-081617-404.png
20191121-081617-695.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080056-263.png
20191121-080056-564.png
20191121-080134-668.png
20191121-080134-883.png
20191121-080210-347.png
20191121-080210-743.png
20191121-080247-974.png
20191121-080248-308.png
20191121-080324-908.png
20191121-080325-232.png
20191121-080401-816.png
20191121-080402-028.png
20191121-080438-710.png
20191121-080438-944.png
20191121-080515-538.png
20191121-080515-750.png
20191121-080550-730.png
20191121-080551-057.png
20191121-080627-609.png
20191121-080627-823.png
20191121-080704-803.png
20191121-080705-008.png
20191121-080800-063.png
20191121-080800-330.png
20191121-081404-141.png
20191121-081404-376.png
20191121-081439-942.png
20191121-081440-162.png
20191121-081515-667.png
20191121-081515-958.png
20191121-081551-868.png
20191121-081552-086.png
20191121-081627-002.png
20191121-081627-198.png
20191121-081708-202.png
20191121-081708-499.png
20191121-081745-284.png
20191121-081745-493.png
20191121-081821-619.png
20191121-081821-880.png
20191121-081919-142.png
20191121-081919-531.png
20191121-081955-862.png
20191121-081956-163.png

@marcus-herrmann
Copy link
Copy Markdown
Contributor Author

marcus-herrmann commented Nov 21, 2019

I assume the tests are failing because of the new DOM structure. Since I cannot get the tests to run, could anybody assist me in remedying?

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080122-999.png
20191121-080123-270.png
20191121-080157-519.png
20191121-080157-784.png
20191121-080231-613.png
20191121-080231-816.png
20191121-080305-788.png
20191121-080306-002.png
20191121-080339-779.png
20191121-080340-051.png
20191121-080413-555.png
20191121-080413-791.png
20191121-080507-260.png
20191121-080507-524.png
20191121-080601-374.png
20191121-080601-621.png
20191121-080635-392.png
20191121-080635-613.png
20191121-080709-073.png
20191121-080709-351.png
20191121-080742-843.png
20191121-080743-079.png
20191121-080836-767.png
20191121-080837-046.png
20191121-080910-099.png
20191121-080910-349.png
20191121-080943-824.png
20191121-080944-040.png
20191121-081017-345.png
20191121-081017-548.png
20191121-081050-865.png
20191121-081051-069.png
20191121-081124-579.png
20191121-081124-780.png
20191121-081158-221.png
20191121-081158-454.png
20191121-081232-714.png
20191121-081233-095.png
20191121-081306-273.png
20191121-081306-605.png
20191121-081339-901.png
20191121-081340-227.png
20191121-081413-779.png
20191121-081414-070.png
20191121-081447-379.png
20191121-081447-652.png
20191121-081521-624.png
20191121-081521-860.png
20191121-081615-712.png
20191121-081616-023.png
20191121-081649-500.png
20191121-081649-723.png
20191121-081729-221.png
20191121-081729-497.png
20191121-081809-292.png
20191121-081809-625.png
20191121-081848-615.png
20191121-081848-921.png
20191121-081947-509.png
20191121-081947-855.png
20191121-082026-646.png
20191121-082026-965.png
20191121-082125-873.png
20191121-082126-092.png
20191121-082209-260.png
20191121-082209-584.png
20191121-082253-946.png
20191121-082254-172.png
20191121-082341-397.png
20191121-082341-817.png
20191121-082444-845.png
20191121-082445-162.png
20191121-082529-677.png
20191121-082529-938.png
20191121-082611-722.png
20191121-082611-944.png
20191121-082654-343.png
20191121-082654-576.png
20191121-082758-398.png
20191121-082758-605.png

@marcus-herrmann marcus-herrmann requested review from PVince81 and removed request for DeepDiver1975 November 21, 2019 08:28
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests SharingPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-075958-624.png
20191121-075958-884.png
20191121-080039-651.png
20191121-080039-885.png
20191121-080120-601.png
20191121-080120-906.png
20191121-080202-027.png
20191121-080202-272.png
20191121-080242-491.png
20191121-080242-713.png
20191121-080323-069.png
20191121-080323-379.png
20191121-080403-693.png
20191121-080404-163.png
20191121-080444-965.png
20191121-080445-177.png
20191121-080526-631.png
20191121-080526-820.png
20191121-080606-818.png
20191121-080607-047.png
20191121-080647-128.png
20191121-080647-334.png
20191121-080727-398.png
20191121-080727-611.png
20191121-080808-299.png
20191121-080808-612.png
20191121-080848-922.png
20191121-080849-134.png
20191121-080929-285.png
20191121-080929-529.png
20191121-081009-215.png
20191121-081009-425.png
20191121-081045-467.png
20191121-081045-726.png
20191121-081120-562.png
20191121-081120-758.png
20191121-081155-890.png
20191121-081156-165.png
20191121-081231-128.png
20191121-081231-469.png
20191121-081307-071.png
20191121-081307-279.png
20191121-081342-778.png
20191121-081342-988.png
20191121-081418-507.png
20191121-081418-701.png
20191121-081453-924.png
20191121-081454-159.png
20191121-081529-125.png
20191121-081529-316.png
20191121-081604-377.png
20191121-081604-571.png
20191121-081639-885.png
20191121-081640-256.png
20191121-081715-199.png
20191121-081715-400.png
20191121-081750-958.png
20191121-081751-212.png
20191121-081826-914.png
20191121-081827-146.png
20191121-081903-152.png
20191121-081903-432.png
20191121-081939-121.png
20191121-081939-453.png
20191121-082014-937.png
20191121-082015-208.png
20191121-082051-227.png
20191121-082051-474.png
20191121-082126-761.png
20191121-082126-979.png
20191121-082202-159.png
20191121-082202-460.png
20191121-082237-235.png
20191121-082237-490.png
20191121-082312-562.png
20191121-082312-772.png
20191121-082348-440.png
20191121-082348-685.png
20191121-082423-855.png
20191121-082424-137.png
20191121-082459-199.png
20191121-082459-395.png
20191121-082535-111.png
20191121-082535-390.png
20191121-082610-445.png
20191121-082610-650.png
20191121-082645-865.png
20191121-082646-068.png
20191121-082721-216.png
20191121-082721-479.png
20191121-082756-363.png
20191121-082756-575.png
20191121-082831-799.png
20191121-082832-164.png
20191121-082906-940.png
20191121-082907-169.png
20191121-082942-333.png
20191121-082942-530.png
20191121-083017-869.png
20191121-083018-165.png
20191121-083113-720.png
20191121-083113-906.png
20191121-083149-067.png
20191121-083149-261.png
20191121-083224-420.png
20191121-083224-706.png
20191121-083259-301.png
20191121-083259-559.png
20191121-083354-838.png
20191121-083355-104.png
20191121-083430-686.png
20191121-083430-913.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080317-059.png
20191121-080317-333.png
20191121-080403-611.png
20191121-080404-033.png
20191121-080449-375.png
20191121-080449-624.png
20191121-080535-580.png
20191121-080535-931.png
20191121-080621-370.png
20191121-080621-723.png
20191121-080707-071.png
20191121-080707-487.png
20191121-080813-898.png
20191121-080814-169.png
20191121-080857-553.png
20191121-080857-826.png
20191121-080942-032.png
20191121-080942-550.png
20191121-081027-313.png
20191121-081027-695.png
20191121-081113-394.png
20191121-081113-842.png
20191121-081217-858.png
20191121-081218-297.png
20191121-081302-158.png
20191121-081302-601.png
20191121-081346-535.png
20191121-081346-930.png
20191121-081532-571.png
20191121-081533-004.png
20191121-081619-545.png
20191121-081619-957.png
20191121-081706-035.png
20191121-081706-284.png
20191121-081752-959.png
20191121-081753-342.png
20191121-082037-442.png
20191121-082037-667.png
20191121-082155-245.png
20191121-082155-652.png
20191121-082313-909.png
20191121-082314-121.png
20191121-082435-395.png
20191121-082435-608.png
20191121-082534-380.png
20191121-082534-726.png
20191121-082634-424.png
20191121-082634-783.png
20191121-082721-062.png
20191121-082721-499.png
20191121-082807-339.png
20191121-082807-746.png
20191121-082922-200.png
20191121-082922-595.png
20191121-083019-373.png
20191121-083019-691.png
20191121-083105-611.png
20191121-083105-982.png
20191121-083149-060.png
20191121-083149-454.png
20191121-083241-793.png
20191121-083242-115.png
20191121-083334-970.png
20191121-083335-409.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080052-861.png
20191121-080053-128.png
20191121-080128-093.png
20191121-080128-313.png
20191121-080202-495.png
20191121-080202-693.png
20191121-080236-860.png
20191121-080237-082.png
20191121-080331-630.png
20191121-080331-833.png
20191121-080426-107.png
20191121-080426-383.png
20191121-080500-207.png
20191121-080500-453.png
20191121-080534-460.png
20191121-080534-687.png
20191121-080608-389.png
20191121-080608-597.png
20191121-080642-403.png
20191121-080642-625.png
20191121-080716-261.png
20191121-080716-521.png
20191121-080750-185.png
20191121-080750-463.png
20191121-080823-875.png
20191121-080824-159.png
20191121-080857-458.png
20191121-080857-688.png
20191121-080932-321.png
20191121-080932-604.png
20191121-081026-270.png
20191121-081026-591.png
20191121-081100-173.png
20191121-081100-465.png
20191121-081154-263.png
20191121-081154-481.png
20191121-081228-221.png
20191121-081228-432.png
20191121-081301-674.png
20191121-081301-886.png
20191121-081336-034.png
20191121-081336-251.png
20191121-081409-444.png
20191121-081409-677.png
20191121-081443-226.png
20191121-081443-447.png
20191121-081519-400.png
20191121-081519-618.png
20191121-081558-855.png
20191121-081559-078.png
20191121-081639-176.png
20191121-081639-587.png
20191121-081722-674.png
20191121-081722-904.png
20191121-081823-451.png
20191121-081823-818.png
20191121-081902-878.png
20191121-081903-089.png
20191121-081943-777.png
20191121-081943-970.png
20191121-082043-455.png
20191121-082043-656.png
20191121-082123-131.png
20191121-082123-503.png
20191121-082202-817.png
20191121-082203-025.png
20191121-082303-544.png
20191121-082303-781.png
20191121-082342-330.png
20191121-082342-658.png
20191121-082441-657.png
20191121-082442-188.png
20191121-082522-976.png
20191121-082523-161.png
20191121-082621-807.png
20191121-082622-196.png
20191121-082704-313.png
20191121-082704-523.png
20191121-082742-492.png
20191121-082742-961.png
20191121-082821-475.png
20191121-082821-726.png
20191121-082903-707.png
20191121-082904-118.png
20191121-082946-235.png
20191121-082946-639.png
20191121-083028-341.png
20191121-083028-697.png
20191121-083105-958.png
20191121-083106-206.png
20191121-083204-693.png
20191121-083204-984.png
20191121-083243-744.png
20191121-083243-953.png
20191121-083324-379.png
20191121-083324-597.png
20191121-083403-237.png
20191121-083403-453.png
20191121-083445-839.png
20191121-083446-058.png
20191121-083528-485.png
20191121-083528-799.png
20191121-083607-186.png
20191121-083607-613.png
20191121-083652-294.png
20191121-083652-625.png
20191121-083736-760.png
20191121-083737-022.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080150-455.png
20191121-080150-693.png
20191121-080317-272.png
20191121-080317-487.png
20191121-080425-599.png
20191121-080425-812.png
20191121-080534-076.png
20191121-080534-394.png
20191121-080639-239.png
20191121-080639-637.png
20191121-080748-333.png
20191121-080748-560.png
20191121-080854-176.png
20191121-080854-410.png
20191121-080935-398.png
20191121-080935-632.png
20191121-081038-521.png
20191121-081038-797.png
20191121-081120-502.png
20191121-081120-849.png
20191121-081202-219.png
20191121-081202-556.png
20191121-081304-651.png
20191121-081304-880.png
20191121-081347-018.png
20191121-081347-302.png
20191121-081449-093.png
20191121-081449-336.png
20191121-081550-132.png
20191121-081550-412.png
20191121-081632-015.png
20191121-081632-233.png
20191121-081725-826.png
20191121-081726-236.png
20191121-081815-547.png
20191121-081816-081.png
20191121-081906-400.png
20191121-081906-802.png
20191121-082015-365.png
20191121-082015-710.png
20191121-082101-563.png
20191121-082101-876.png
20191121-082147-731.png
20191121-082147-953.png
20191121-082233-566.png
20191121-082233-764.png
20191121-082319-854.png
20191121-082320-259.png
20191121-082404-475.png
20191121-082404-706.png
20191121-082511-367.png
20191121-082511-612.png
20191121-082551-558.png
20191121-082551-866.png
20191121-082631-691.png
20191121-082631-959.png
20191121-082711-709.png
20191121-082712-017.png
20191121-082803-299.png
20191121-082803-524.png
20191121-082850-559.png
20191121-082850-791.png
20191121-082931-373.png
20191121-082931-627.png
20191121-083011-439.png
20191121-083011-695.png
20191121-083052-442.png
20191121-083052-775.png
20191121-083133-021.png
20191121-083133-271.png
20191121-083252-737.png
20191121-083253-142.png
20191121-083336-377.png
20191121-083336-734.png
20191121-083419-076.png
20191121-083419-420.png
20191121-083522-822.png
20191121-083523-152.png
20191121-083627-785.png
20191121-083628-121.png
20191121-083750-221.png
20191121-083750-426.png
20191121-083834-486.png
20191121-083834-707.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-080738-968.png
20191121-080817-149.png
20191121-080851-716.png
20191121-080926-817.png
20191121-081325-493.png
20191121-081325-601.png
20191121-081403-029.png
20191121-081403-184.png
20191121-081439-893.png
20191121-081439-958.png
20191121-081516-446.png
20191121-081516-562.png
20191121-081552-814.png
20191121-081552-898.png
20191121-081629-388.png
20191121-081629-503.png
20191121-081716-752.png
20191121-081716-918.png
20191121-081801-240.png
20191121-081801-366.png
20191121-081846-226.png
20191121-081846-297.png
20191121-081929-987.png
20191121-081930-091.png
20191121-082016-461.png
20191121-082016-586.png
20191121-082104-275.png
20191121-082104-365.png
20191121-082151-139.png
20191121-082151-271.png
20191121-082240-421.png
20191121-082240-602.png
20191121-082322-775.png
20191121-082322-906.png
20191121-082402-430.png
20191121-082402-556.png
20191121-082443-243.png
20191121-082443-405.png
20191121-082523-660.png
20191121-082523-843.png
20191121-082604-722.png
20191121-082604-842.png
20191121-082645-847.png
20191121-082646-006.png
20191121-082922-336.png
20191121-082922-417.png
20191121-083000-971.png
20191121-083001-165.png
20191121-083039-512.png
20191121-083039-648.png
20191121-083119-668.png
20191121-083119-765.png
20191121-083157-934.png
20191121-083158-076.png
20191121-083237-123.png
20191121-083237-280.png
20191121-083318-506.png
20191121-083318-695.png
20191121-083400-259.png
20191121-083400-393.png
20191121-083441-439.png
20191121-083441-518.png
20191121-083521-643.png
20191121-083521-724.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-081057-467.png
20191121-081144-293.png
20191121-081226-386.png
20191121-081309-054.png
20191121-081839-005.png
20191121-081839-191.png
20191121-081935-541.png
20191121-081935-815.png
20191121-082031-033.png
20191121-082031-305.png
20191121-082124-699.png
20191121-082124-829.png
20191121-082219-147.png
20191121-082219-398.png
20191121-082310-548.png
20191121-082310-924.png
20191121-082423-763.png
20191121-082424-015.png
20191121-082519-694.png
20191121-082519-835.png
20191121-082616-037.png
20191121-082616-323.png
20191121-082715-082.png
20191121-082715-362.png
20191121-082812-726.png
20191121-082812-984.png
20191121-082910-530.png
20191121-082910-759.png
20191121-083007-783.png
20191121-083007-927.png
20191121-083105-852.png
20191121-083106-116.png
20191121-083217-507.png
20191121-083217-692.png
20191121-083308-069.png
20191121-083308-362.png
20191121-083420-482.png
20191121-083420-864.png
20191121-083511-344.png
20191121-083511-582.png
20191121-083600-266.png
20191121-083600-571.png
20191121-083711-474.png
20191121-083711-646.png
20191121-084024-947.png
20191121-084025-117.png
20191121-084111-123.png
20191121-084111-337.png
20191121-084156-762.png
20191121-084156-921.png
20191121-084244-513.png
20191121-084244-773.png
20191121-084333-802.png
20191121-084334-052.png
20191121-084419-567.png
20191121-084419-826.png
20191121-084506-780.png
20191121-084506-971.png
20191121-084613-830.png
20191121-084614-042.png
20191121-084658-646.png
20191121-084658-839.png
20191121-084746-287.png
20191121-084746-602.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 21, 2019

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6609/

20191121-081655-317.png
20191121-083237-758.png
20191121-083323-180.png
20191121-083427-557.png
20191121-083537-015.png
20191121-083643-375.png
20191121-083752-853.png
20191121-083858-447.png
20191121-084025-958.png
20191121-084134-433.png
20191121-084302-186.png
20191121-084415-243.png
20191121-084537-731.png
20191121-084706-099.png
20191121-084851-680.png
20191121-090036-547.png
20191121-090122-649.png
20191121-090230-521.png
20191121-090338-275.png
20191121-090424-142.png
20191121-090530-882.png
20191121-090614-555.png
20191121-090719-845.png
20191121-090804-790.png
20191121-090850-515.png
20191121-090935-999.png
20191121-091022-691.png

@marcus-herrmann marcus-herrmann force-pushed the feature/implement-oc-tabbed branch from 2354354 to 4040b0f Compare November 28, 2019 07:50
@marcus-herrmann
Copy link
Copy Markdown
Contributor Author

marcus-herrmann commented Nov 28, 2019

@PVince81 PR is rebased now

@marcus-herrmann marcus-herrmann force-pushed the feature/implement-oc-tabbed branch from 4040b0f to 371230c Compare November 28, 2019 07:54
@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Nov 28, 2019

you should now be able to rebase and then update the design system package so that the logic can work

@marcus-herrmann
Copy link
Copy Markdown
Contributor Author

marcus-herrmann commented Nov 28, 2019

@PVince81 Like I wrote, I just rebased this morning. To my grasp I did update ODS (see: owncloud/owncloud-design-system#535 but it needs review first), or do you mean something else regarding these topics, for example having phoenix's package.json point to the ODS commit needed for this to run without merging this very PR?

PVince81
PVince81 reviewed Nov 28, 2019
View reviewed changes
@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Nov 28, 2019

@marcus-herrmann if you run yarn upgrade owncloud-design-system it should grab the latest and yarn.lock will be modified. I don't see a modified yarn.lock in this PR, so CI will not see it either and tests will fail.

Also see conflicts that need resolution

@marcus-herrmann marcus-herrmann force-pushed the feature/implement-oc-tabbed branch from 371230c to 28e2759 Compare November 28, 2019 10:08
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102208-124.png
20191128-102208-449.png
20191128-102247-152.png
20191128-102247-369.png
20191128-102346-172.png
20191128-102346-481.png
20191128-102427-325.png
20191128-102427-546.png
20191128-102528-525.png
20191128-102528-871.png
20191128-102610-073.png
20191128-102610-415.png
20191128-102652-772.png
20191128-102652-959.png
20191128-102734-506.png
20191128-102734-861.png
20191128-102816-416.png
20191128-102816-657.png
20191128-102900-860.png
20191128-102901-227.png
20191128-102944-243.png
20191128-102944-553.png
20191128-103027-566.png
20191128-103027-755.png
20191128-103127-230.png
20191128-103127-421.png
20191128-103207-114.png
20191128-103207-339.png
20191128-103247-344.png
20191128-103247-617.png
20191128-103327-598.png
20191128-103327-833.png
20191128-103412-395.png
20191128-103412-683.png
20191128-103455-759.png
20191128-103456-069.png
20191128-103537-936.png
20191128-103538-253.png
20191128-103621-193.png
20191128-103621-425.png
20191128-103721-127.png
20191128-103721-432.png
20191128-103759-104.png
20191128-103759-281.png
20191128-103837-471.png
20191128-103837-747.png
20191128-103913-871.png
20191128-103914-067.png
20191128-103946-038.png
20191128-103946-291.png
20191128-104018-419.png
20191128-104018-647.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102357-634.png
20191128-102357-793.png
20191128-102434-742.png
20191128-102434-904.png
20191128-102509-610.png
20191128-102509-790.png
20191128-102544-138.png
20191128-102544-429.png
20191128-102619-600.png
20191128-102619-830.png
20191128-102714-528.png
20191128-102714-724.png
20191128-102748-440.png
20191128-102748-615.png
20191128-102821-790.png
20191128-102822-219.png
20191128-102855-107.png
20191128-102855-334.png
20191128-102927-765.png
20191128-102927-949.png
20191128-103004-046.png
20191128-103004-356.png
20191128-103037-514.png
20191128-103037-887.png
20191128-103134-288.png
20191128-103134-611.png
20191128-103207-403.png
20191128-103207-591.png
20191128-103322-996.png
20191128-103323-225.png
20191128-103400-577.png
20191128-103400-955.png
20191128-103438-577.png
20191128-103438-888.png
20191128-103515-972.png
20191128-103516-282.png
20191128-103716-410.png
20191128-103716-683.png
20191128-103757-488.png
20191128-103757-768.png
20191128-103858-119.png
20191128-103858-283.png
20191128-103940-465.png
20191128-103940-778.png
20191128-104021-357.png
20191128-104021-551.png
20191128-104100-782.png
20191128-104100-982.png
20191128-104136-519.png
20191128-104136-917.png
20191128-104234-741.png
20191128-104234-922.png
20191128-104315-740.png
20191128-104316-294.png
20191128-104359-202.png
20191128-104359-471.png
20191128-104433-882.png
20191128-104434-149.png
20191128-104509-012.png
20191128-104509-271.png
20191128-104546-747.png
20191128-104546-922.png
20191128-104624-488.png
20191128-104624-766.png
20191128-104905-018.png
20191128-104905-195.png
20191128-104939-657.png
20191128-104939-922.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests SharingFolderPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102218-489.png
20191128-102218-681.png
20191128-102255-779.png
20191128-102255-969.png
20191128-102331-584.png
20191128-102331-934.png
20191128-102411-658.png
20191128-102412-029.png
20191128-102449-389.png
20191128-102449-676.png
20191128-102526-326.png
20191128-102526-630.png
20191128-102603-108.png
20191128-102603-367.png
20191128-102640-409.png
20191128-102640-600.png
20191128-102718-369.png
20191128-102718-977.png
20191128-102758-570.png
20191128-102758-901.png
20191128-102858-115.png
20191128-102858-447.png
20191128-102936-251.png
20191128-102936-490.png
20191128-103034-807.png
20191128-103034-984.png
20191128-103112-908.png
20191128-103113-065.png
20191128-103211-830.png
20191128-103212-173.png
20191128-103310-104.png
20191128-103310-390.png
20191128-103347-956.png
20191128-103348-146.png
20191128-103446-030.png
20191128-103446-231.png
20191128-103524-162.png
20191128-103524-520.png
20191128-103602-349.png
20191128-103602-576.png
20191128-103640-041.png
20191128-103640-411.png
20191128-103718-005.png
20191128-103718-306.png
20191128-103756-086.png
20191128-103756-282.png
20191128-103835-267.png
20191128-103835-464.png
20191128-103934-570.png
20191128-103934-749.png
20191128-104029-182.png
20191128-104029-413.png
20191128-104101-755.png
20191128-104102-157.png
20191128-104141-326.png
20191128-104141-705.png
20191128-104215-248.png
20191128-104215-455.png
20191128-104250-851.png
20191128-104251-177.png
20191128-104325-109.png
20191128-104325-301.png
20191128-104401-512.png
20191128-104401-693.png
20191128-104440-136.png
20191128-104440-459.png
20191128-104518-573.png
20191128-104518-759.png
20191128-104556-914.png
20191128-104557-238.png
20191128-104635-755.png
20191128-104636-082.png
20191128-104715-070.png
20191128-104715-378.png
20191128-104814-609.png
20191128-104814-806.png
20191128-104914-050.png
20191128-104914-244.png
20191128-104952-855.png
20191128-104953-090.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102242-041.png
20191128-102242-349.png
20191128-102316-472.png
20191128-102316-821.png
20191128-102350-398.png
20191128-102350-649.png
20191128-102423-981.png
20191128-102424-276.png
20191128-102517-654.png
20191128-102518-053.png
20191128-102551-577.png
20191128-102552-011.png
20191128-102625-239.png
20191128-102625-417.png
20191128-102718-881.png
20191128-102719-123.png
20191128-102812-291.png
20191128-102812-483.png
20191128-102906-872.png
20191128-102907-041.png
20191128-102938-304.png
20191128-102938-471.png
20191128-103011-224.png
20191128-103011-571.png
20191128-103044-806.png
20191128-103044-999.png
20191128-103138-098.png
20191128-103138-287.png
20191128-103231-331.png
20191128-103231-644.png
20191128-103304-630.png
20191128-103304-981.png
20191128-103337-895.png
20191128-103338-163.png
20191128-103427-458.png
20191128-103427-712.png
20191128-103521-065.png
20191128-103521-365.png
20191128-103614-365.png
20191128-103614-621.png
20191128-103644-770.png
20191128-103644-986.png
20191128-103714-213.png
20191128-103714-445.png
20191128-103803-898.png
20191128-103804-140.png
20191128-103833-533.png
20191128-103833-729.png
20191128-103922-687.png
20191128-103922-892.png
20191128-103951-894.png
20191128-103952-104.png
20191128-104041-803.png
20191128-104042-060.png
20191128-104114-001.png
20191128-104114-175.png
20191128-104205-774.png
20191128-104206-082.png
20191128-104300-808.png
20191128-104301-076.png
20191128-104346-113.png
20191128-104346-269.png
20191128-104419-371.png
20191128-104419-540.png
20191128-104514-775.png
20191128-104514-946.png
20191128-104611-020.png
20191128-104611-236.png
20191128-104649-294.png
20191128-104649-716.png
20191128-104747-013.png
20191128-104747-189.png
20191128-104825-213.png
20191128-104825-562.png
20191128-104902-395.png
20191128-104902-674.png
20191128-104941-082.png
20191128-104941-251.png
20191128-105019-187.png
20191128-105019-358.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102402-086.png
20191128-102402-305.png
20191128-102443-066.png
20191128-102443-256.png
20191128-102542-758.png
20191128-102543-082.png
20191128-102701-222.png
20191128-102701-536.png
20191128-102738-533.png
20191128-102738-724.png
20191128-102835-603.png
20191128-102835-809.png
20191128-102931-798.png
20191128-102932-320.png
20191128-103029-649.png
20191128-103029-843.png
20191128-103110-261.png
20191128-103110-545.png
20191128-103228-346.png
20191128-103228-671.png
20191128-103323-937.png
20191128-103324-220.png
20191128-103404-636.png
20191128-103405-074.png
20191128-103444-617.png
20191128-103444-903.png
20191128-103523-955.png
20191128-103524-247.png
20191128-103620-075.png
20191128-103620-439.png
20191128-103720-852.png
20191128-103721-120.png
20191128-103819-969.png
20191128-103820-289.png
20191128-103856-921.png
20191128-103857-137.png
20191128-103936-785.png
20191128-103937-080.png
20191128-104034-603.png
20191128-104034-798.png
20191128-104132-068.png
20191128-104132-324.png
20191128-104208-876.png
20191128-104209-120.png
20191128-104304-225.png
20191128-104304-405.png
20191128-104345-293.png
20191128-104345-587.png
20191128-104438-934.png
20191128-104439-153.png
20191128-104516-120.png
20191128-104516-434.png
20191128-104552-282.png
20191128-104552-456.png
20191128-104628-662.png
20191128-104628-882.png
20191128-104707-228.png
20191128-104707-540.png
20191128-104746-187.png
20191128-104746-435.png
20191128-104843-410.png
20191128-104843-601.png
20191128-104918-239.png
20191128-104918-434.png
20191128-104953-697.png
20191128-104953-884.png
20191128-105050-511.png
20191128-105050-712.png
20191128-105145-509.png
20191128-105145-718.png
20191128-105220-163.png
20191128-105220-368.png
20191128-105258-615.png
20191128-105258-820.png
20191128-105351-307.png
20191128-105351-527.png
20191128-105443-694.png
20191128-105443-857.png
20191128-105517-117.png
20191128-105517-463.png
20191128-105555-828.png
20191128-105556-102.png
20191128-105631-196.png
20191128-105631-560.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102149-461.png
20191128-102149-889.png
20191128-102250-535.png
20191128-102250-928.png
20191128-102349-615.png
20191128-102349-973.png
20191128-102449-884.png
20191128-102450-119.png
20191128-102529-531.png
20191128-102530-013.png
20191128-102609-155.png
20191128-102609-526.png
20191128-102647-701.png
20191128-102647-886.png
20191128-102726-353.png
20191128-102726-667.png
20191128-102804-254.png
20191128-102804-567.png
20191128-102842-897.png
20191128-102843-329.png
20191128-102922-123.png
20191128-102922-316.png
20191128-103001-461.png
20191128-103001-902.png
20191128-103041-419.png
20191128-103041-615.png
20191128-103121-127.png
20191128-103121-501.png
20191128-103201-553.png
20191128-103201-744.png
20191128-103238-845.png
20191128-103239-072.png
20191128-103312-409.png
20191128-103312-749.png
20191128-103405-374.png
20191128-103405-578.png
20191128-103438-610.png
20191128-103438-815.png
20191128-103532-072.png
20191128-103532-294.png
20191128-103625-089.png
20191128-103625-330.png
20191128-103657-844.png
20191128-103658-063.png
20191128-103730-926.png
20191128-103731-218.png
20191128-103823-716.png
20191128-103823-931.png
20191128-103856-104.png
20191128-103856-315.png
20191128-103948-988.png
20191128-103949-200.png
20191128-104041-294.png
20191128-104041-599.png
20191128-104135-364.png
20191128-104135-562.png
20191128-104211-314.png
20191128-104211-568.png
20191128-104246-794.png
20191128-104247-099.png
20191128-104324-273.png
20191128-104324-647.png
20191128-104403-485.png
20191128-104403-741.png
20191128-104502-536.png
20191128-104502-864.png
20191128-104540-521.png
20191128-104540-842.png
20191128-104619-716.png
20191128-104620-083.png
20191128-104718-262.png
20191128-104718-697.png
20191128-104756-111.png
20191128-104756-302.png
20191128-104855-040.png
20191128-104855-219.png
20191128-104933-783.png
20191128-104934-034.png
20191128-105011-773.png
20191128-105012-006.png
20191128-105049-836.png
20191128-105050-172.png
20191128-105149-112.png
20191128-105149-415.png
20191128-105227-662.png
20191128-105227-940.png
20191128-105305-563.png
20191128-105305-760.png
20191128-105343-836.png
20191128-105344-024.png
20191128-105422-810.png
20191128-105423-143.png
20191128-105502-440.png
20191128-105502-830.png
20191128-105540-337.png
20191128-105540-672.png
20191128-105643-562.png
20191128-105643-747.png
20191128-105723-795.png
20191128-105723-989.png
20191128-105802-359.png
20191128-105802-603.png
20191128-105841-143.png
20191128-105841-470.png
20191128-105921-298.png
20191128-105921-485.png
20191128-110001-839.png
20191128-110002-161.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6876/

20191128-103517-392.png
20191128-103609-152.png
20191128-103641-199.png
20191128-103713-291.png
20191128-103804-779.png
20191128-103857-979.png
20191128-103949-751.png
20191128-104101-544.png
20191128-104200-636.png
20191128-104316-008.png
20191128-104452-921.png
20191128-104551-421.png
20191128-104657-322.png
20191128-104822-192.png
20191128-105859-643.png
20191128-105937-954.png
20191128-110017-276.png
20191128-110055-654.png
20191128-110132-784.png
20191128-110210-488.png
20191128-110247-683.png
20191128-110325-351.png
20191128-110403-844.png
20191128-110438-087.png
20191128-110532-335.png
20191128-110606-956.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-103032-804.png
20191128-103032-895.png
20191128-103032-993.png
20191128-103033-104.png
20191128-103106-757.png
20191128-103106-873.png
20191128-103106-996.png
20191128-103107-092.png
20191128-103142-402.png
20191128-103217-126.png
20191128-103637-417.png
20191128-103637-545.png
20191128-103717-506.png
20191128-103717-587.png
20191128-103756-533.png
20191128-103756-671.png
20191128-103837-981.png
20191128-103838-109.png
20191128-103920-880.png
20191128-103920-985.png
20191128-104002-051.png
20191128-104002-169.png
20191128-104044-222.png
20191128-104044-290.png
20191128-104123-991.png
20191128-104124-122.png
20191128-104204-763.png
20191128-104204-841.png
20191128-104245-536.png
20191128-104245-626.png
20191128-104455-864.png
20191128-104456-036.png
20191128-104600-308.png
20191128-104600-404.png
20191128-104646-520.png
20191128-104646-664.png
20191128-104729-402.png
20191128-104729-474.png
20191128-104827-358.png
20191128-104827-471.png
20191128-104924-018.png
20191128-104924-147.png
20191128-105001-121.png
20191128-105001-252.png
20191128-105038-431.png
20191128-105038-538.png
20191128-105115-235.png
20191128-105115-299.png
20191128-105152-883.png
20191128-105153-024.png
20191128-105410-955.png
20191128-105411-238.png
20191128-105446-651.png
20191128-105446-771.png
20191128-105522-378.png
20191128-105522-517.png
20191128-105556-775.png
20191128-105556-869.png
20191128-105633-196.png
20191128-105633-292.png
20191128-105707-858.png
20191128-105707-980.png
20191128-105743-278.png
20191128-105743-369.png
20191128-105820-290.png
20191128-105820-424.png
20191128-105917-788.png
20191128-105917-846.png
20191128-105953-548.png
20191128-105953-617.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-103054-679.png
20191128-103054-791.png
20191128-103054-951.png
20191128-103055-096.png
20191128-103129-589.png
20191128-103129-771.png
20191128-103129-903.png
20191128-103130-020.png
20191128-103205-293.png
20191128-103239-578.png
20191128-103703-355.png
20191128-103703-544.png
20191128-103802-740.png
20191128-103802-879.png
20191128-103843-617.png
20191128-103843-905.png
20191128-103926-812.png
20191128-103927-109.png
20191128-104008-866.png
20191128-104009-100.png
20191128-104112-147.png
20191128-104112-415.png
20191128-104151-841.png
20191128-104151-967.png
20191128-104232-254.png
20191128-104232-451.png
20191128-104311-085.png
20191128-104311-237.png
20191128-104356-574.png
20191128-104356-772.png
20191128-104550-448.png
20191128-104550-570.png
20191128-104634-778.png
20191128-104634-909.png
20191128-104737-700.png
20191128-104738-000.png
20191128-104838-692.png
20191128-104838-924.png
20191128-104916-544.png
20191128-104916-756.png
20191128-105014-500.png
20191128-105014-641.png
20191128-105051-158.png
20191128-105051-412.png
20191128-105128-669.png
20191128-105128-778.png
20191128-105227-793.png
20191128-105227-973.png
20191128-105308-137.png
20191128-105308-280.png
20191128-105526-933.png
20191128-105527-137.png
20191128-105601-793.png
20191128-105602-059.png
20191128-105637-736.png
20191128-105637-933.png
20191128-105733-504.png
20191128-105733-636.png
20191128-105810-034.png
20191128-105810-266.png
20191128-105847-895.png
20191128-105848-100.png
20191128-105923-317.png
20191128-105923-514.png
20191128-105959-134.png
20191128-105959-314.png
20191128-110035-396.png
20191128-110035-613.png
20191128-110109-745.png
20191128-110109-914.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-102227-428.png
20191128-102227-697.png
20191128-102319-869.png
20191128-102320-087.png
20191128-102412-440.png
20191128-102412-828.png
20191128-102505-488.png
20191128-102505-671.png
20191128-102537-781.png
20191128-102538-088.png
20191128-102609-936.png
20191128-102610-187.png
20191128-102702-320.png
20191128-102702-573.png
20191128-102734-728.png
20191128-102734-936.png
20191128-102807-172.png
20191128-102807-378.png
20191128-102859-437.png
20191128-102859-620.png
20191128-102931-747.png
20191128-102932-038.png
20191128-103004-187.png
20191128-103004-498.png
20191128-103557-108.png
20191128-103557-263.png
20191128-103628-828.png
20191128-103629-005.png
20191128-103721-839.png
20191128-103722-018.png
20191128-103814-815.png
20191128-103815-040.png
20191128-103845-968.png
20191128-103846-148.png
20191128-103917-488.png
20191128-103917-697.png
20191128-103951-174.png
20191128-103951-362.png
20191128-104024-466.png
20191128-104024-645.png
20191128-104056-207.png
20191128-104056-504.png
20191128-104129-913.png
20191128-104130-179.png
20191128-104201-332.png
20191128-104201-583.png
20191128-104234-300.png
20191128-104234-479.png
20191128-104326-335.png
20191128-104326-511.png
20191128-104358-753.png
20191128-104358-935.png
20191128-104451-252.png
20191128-104451-544.png
20191128-104524-068.png
20191128-104524-229.png
20191128-104616-590.png
20191128-104616-766.png
20191128-104648-898.png
20191128-104649-172.png
20191128-104741-439.png
20191128-104741-606.png
20191128-104834-990.png
20191128-104835-304.png
20191128-104908-829.png
20191128-104909-010.png
20191128-104943-494.png
20191128-104943-804.png
20191128-105036-357.png
20191128-105036-649.png
20191128-105108-560.png
20191128-105108-739.png
20191128-105141-367.png
20191128-105141-536.png
20191128-105234-790.png
20191128-105235-038.png
20191128-105307-525.png
20191128-105307-819.png
20191128-105359-950.png
20191128-105400-299.png
20191128-105452-762.png
20191128-105453-083.png
20191128-105545-792.png
20191128-105546-017.png
20191128-105618-768.png
20191128-105619-100.png
20191128-105711-653.png
20191128-105711-955.png
20191128-105804-754.png
20191128-105804-911.png
20191128-105857-595.png
20191128-105857-859.png
20191128-105930-610.png
20191128-105930-780.png
20191128-110023-386.png
20191128-110023-572.png
20191128-110126-864.png
20191128-110127-091.png
20191128-110158-103.png
20191128-110158-328.png
20191128-110230-436.png
20191128-110230-711.png
20191128-110302-042.png
20191128-110302-225.png
20191128-110344-772.png
20191128-110345-004.png
20191128-110416-237.png
20191128-110416-402.png
20191128-110508-405.png
20191128-110508-603.png
20191128-110558-716.png
20191128-110558-912.png
20191128-110630-364.png
20191128-110630-549.png
20191128-110702-278.png
20191128-110702-469.png
20191128-110735-018.png
20191128-110735-206.png
20191128-110806-828.png
20191128-110806-998.png
20191128-110836-777.png
20191128-110836-962.png
20191128-110907-609.png
20191128-110907-813.png
20191128-110938-900.png
20191128-110939-080.png
20191128-111010-571.png
20191128-111010-769.png
20191128-111101-243.png
20191128-111101-454.png
20191128-111133-132.png
20191128-111133-339.png
20191128-111205-140.png
20191128-111205-343.png
20191128-111238-672.png
20191128-111238-846.png
20191128-111312-150.png
20191128-111312-378.png
20191128-111345-633.png
20191128-111345-814.png
20191128-111417-471.png
20191128-111417-670.png
20191128-111450-800.png
20191128-111450-964.png
20191128-111525-389.png
20191128-111525-587.png
20191128-111557-097.png
20191128-111557-284.png
20191128-111628-751.png
20191128-111628-971.png
20191128-111723-350.png
20191128-111723-626.png
20191128-111756-518.png
20191128-111756-687.png
20191128-111830-533.png
20191128-111830-763.png
20191128-111904-643.png
20191128-111904-831.png
20191128-111958-453.png
20191128-111958-727.png
20191128-112051-608.png
20191128-112051-872.png
20191128-112124-572.png
20191128-112124-747.png
20191128-112157-352.png
20191128-112157-605.png
20191128-112250-114.png
20191128-112250-311.png
20191128-112322-134.png
20191128-112322-382.png
20191128-112415-573.png
20191128-112415-747.png
20191128-112447-294.png
20191128-112447-576.png
20191128-112520-439.png
20191128-112520-645.png
20191128-112554-366.png
20191128-112554-688.png
20191128-112627-203.png
20191128-112627-462.png
20191128-112700-227.png
20191128-112700-425.png
20191128-112733-500.png
20191128-112733-767.png
20191128-112826-451.png
20191128-112826-666.png
20191128-112859-211.png
20191128-112859-396.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Nov 28, 2019

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6877/

20191128-105141-537.png
20191128-105225-019.png
20191128-105328-347.png
20191128-105412-509.png
20191128-105517-146.png
20191128-105642-234.png
20191128-105727-926.png
20191128-105833-009.png
20191128-110000-918.png
20191128-110129-113.png
20191128-110236-701.png
20191128-110404-255.png
20191128-110514-288.png
20191128-110624-411.png
20191128-112035-552.png
20191128-112142-063.png
20191128-112227-829.png
20191128-112314-104.png
20191128-112358-437.png
20191128-112444-934.png
20191128-112533-030.png
20191128-112618-718.png
20191128-112705-986.png
20191128-112753-148.png
20191128-112839-534.png
20191128-112926-749.png

@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Dec 11, 2019

@individual-it can someone help to adjust the tests ?

@individual-it individual-it self-assigned this Dec 11, 2019
@individual-it
Copy link
Copy Markdown
Member

individual-it commented Dec 11, 2019

Assigned myself for fixing the tests

@individual-it individual-it mentioned this pull request Dec 12, 2019
Closed
@individual-it individual-it mentioned this pull request Dec 12, 2019
Closed
@individual-it
Copy link
Copy Markdown
Member

individual-it commented Dec 12, 2019

  • issue: "NEW" - menu does not close after selecting any of the options
    menu-not-hidden

@individual-it

This comment has been minimized.

Sign in to view
@kiranparajuli589
Copy link
Copy Markdown
Contributor

kiranparajuli589 commented Dec 12, 2019

  • issue: - more results option in auto-completion doesn't work properly
    Screenshot from 2019-12-12 15-34-39

@individual-it individual-it mentioned this pull request Dec 13, 2019
Merged
12 tasks
@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Dec 17, 2019

@kiranparajuli589 please rebase. There was a problem on master with share autocomplete "more results" which is solved now.

this PR is only about tab control so any other issue is likely from somewhere else

@PVince81 PVince81 closed this Dec 17, 2019
@PVince81 PVince81 reopened this Dec 17, 2019
@PVince81 PVince81 removed their assignment Sep 3, 2020
@pascalwengerter
Copy link
Copy Markdown
Contributor

pascalwengerter commented Apr 9, 2021

Closed since we've introduced a different approach to the files sidebar and are not using the oc-tabbed component in web right now

@DeepDiver1975 DeepDiver1975 deleted the feature/implement-oc-tabbed branch April 9, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

1 more reviewer

@PVince81 PVince81 PVince81 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@individual-it individual-it

@kiranparajuli589 kiranparajuli589

Labels

Status:Needs-Review Needs review from a maintainer Topic:Accessibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessible tabs

8 participants

@marcus-herrmann @ownclouders @PVince81 @individual-it @kiranparajuli589 @pascalwengerter @micbar @LukasHirt