Implemented virtual scroll in trash bin#2809
Merged
Conversation
LukasHirt
force-pushed
the
feature/trashbin-virtual-scroll
branch
2 times, most recently
from
bbbf291 to
2838d93
Compare
Adjusted selectors Fixed toggle selector Fixed selectors
LukasHirt
force-pushed
the
feature/trashbin-virtual-scroll
branch
from
2838d93 to
f3a4084
Compare
PVince81
approved these changes
Jan 8, 2020
Contributor
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Code looks fine 👍
Glad to see that Trashbin is now also using the FileList base view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-use FileList component with the virtual scroll inside of trash bin.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: