Merged
Conversation
chrismccord
commented
Oct 4, 2023
chrismccord
commented
Oct 4, 2023
vanderhoop
reviewed
Oct 4, 2023
vanderhoop
reviewed
Oct 4, 2023
vanderhoop
reviewed
Oct 4, 2023
vanderhoop
reviewed
Oct 4, 2023
vanderhoop
reviewed
Oct 4, 2023
vanderhoop
reviewed
Oct 4, 2023
Contributor
|
@chrismccord, tags with
|
josevalim
reviewed
Oct 5, 2023
josevalim
reviewed
Oct 5, 2023
josevalim
reviewed
Oct 5, 2023
josevalim
reviewed
Oct 5, 2023
josevalim
reviewed
Oct 11, 2023
josevalim
reviewed
Oct 11, 2023
| // experienced a change which must be a newRender, and thus we can't skip the render. | ||
| // | ||
| // Both optimization flows apply here. newRender is set based on the onlyCids optimization, and | ||
| // we track a deterministic magicId based on the cid. |
josevalim
reviewed
Oct 11, 2023
josevalim
approved these changes
Oct 11, 2023
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Glorious, I have added some comments. Feel free to incorporate or discard them.
Contributor
|
Is this considered a backwards incompatible change? We're assessing it for LVN. I suspect if a LV server updates they'll need a new version of the LVN client |
Member
|
No, the server changes are minimum (1 LOC) and you can safely ignore the additional parameter. |
Co-authored-by: José Valim <jose.valim@dashbit.co>
Co-authored-by: José Valim <jose.valim@dashbit.co>
Member
Author
|
❤️❤️❤️🐥🔥 |
chrismccord
added a commit
that referenced
this pull request
Oct 13, 2023
Co-authored-by: José Valim <jose.valim@dashbit.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.