Give users a helpful error when they try installing packages with the purescript- prefix, which is not required (issue #120)#125
Merged
justinwoo merged 2 commits intopurescript:masterfrom Jul 16, 2018
Dretch:issue-120
Merged
Give users a helpful error when they try installing packages with the purescript- prefix, which is not required (issue #120)#125justinwoo merged 2 commits intopurescript:masterfrom Dretch:issue-120
justinwoo merged 2 commits intopurescript:masterfrom
Dretch:issue-120
Conversation
… purescript- prefix, which is not required (issue #120)
Collaborator
|
Looks fine. Maybe it should also suggest the stripped prefix version even if it isn't a package in the set |
… when xxx is not a valid package
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.