Fix purs command problem for Windows#141
Merged
justinwoo merged 1 commit intopurescript:masterfrom Nov 27, 2018
taiju:fix/purs-command-problem-for-windows
Merged
Fix purs command problem for Windows#141justinwoo merged 1 commit intopurescript:masterfrom taiju:fix/purs-command-problem-for-windows
purs command problem for Windows#141justinwoo merged 1 commit intopurescript:masterfrom
taiju:fix/purs-command-problem-for-windows
Conversation
Collaborator
|
Seems nice to me! Let's see if any others have something to say about this in the coming day(s) |
Collaborator
|
Going to merge and release this. |
This was referenced Nov 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is retry of #69 and #140.
It's based on new knowledge that
inprocorprocfunctions can exec command on Windows if command is absolute path.This fact made the implementation a bit simpler compared to past implementations.
Please review 🙏
Thank you.