str accessor inconsistencies #4334#4339
Merged
mathause merged 9 commits intopydata:masterfrom Aug 15, 2020
Merged
Conversation
mathause
commented
Aug 14, 2020
xarray/core/accessor_str.py
Outdated
| false, only whitespaces will be considered as potentially good | ||
| places for line breaks, but you need to set break_long_words to | ||
| false if you want truly insecable words. (default: True) | ||
| kwargs |
Collaborator
Author
There was a problem hiding this comment.
The docstring was quite incomplete so I though it best to just point to: https://docs.python.org/3/library/textwrap.html#textwrap.TextWrapper
dcherian
approved these changes
Aug 14, 2020
keewis
reviewed
Aug 14, 2020
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
looks good to me.
Most of my suggestions are necessary to make the docs CI pass.
Collaborator
|
Great, this looks good, thanks @mathause |
Co-authored-by: keewis <keewis@users.noreply.github.com>
mathause
commented
Aug 14, 2020
Collaborator
Author
mathause
left a comment
mathause
left a comment
There was a problem hiding this comment.
Thanks everyone for the review!
Contributor
|
@mathause Great! Can you merge when tests pass? |
Contributor
|
Thanks @mathause |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 15, 2020
* upstream/master: (34 commits) Fix bug in computing means of cftime.datetime arrays (pydata#4344) fix some str accessor inconsistencies (pydata#4339) pin matplotlib in ci/requirements/doc.yml (pydata#4340) Clarify drop_vars return value. (pydata#4244) Support explicitly setting a dimension order with to_dataframe() (pydata#4333) Increase support window of all dependencies (pydata#4296) Implement interp for interpolating between chunks of data (dask) (pydata#4155) Add @mathause to current core developers. (pydata#4335) install sphinx-autosummary-accessors from conda-forge (pydata#4332) Use sphinx-accessors-autosummary (pydata#4323) ndrolling fixes (pydata#4329) DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327) pin sphinx to 3.1(pydata#4326) nd-rolling (pydata#4219) Implicit dask import 4164 (pydata#4318) allow customizing the inline repr of a duck array (pydata#4248) silence the known docs CI issues (pydata#4316) enh: fixed pydata#4302 (pydata#4315) Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310) Fix map_blocks example (pydata#4305) ...
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 16, 2020
* upstream/master: (40 commits) Fix bug in computing means of cftime.datetime arrays (pydata#4344) fix some str accessor inconsistencies (pydata#4339) pin matplotlib in ci/requirements/doc.yml (pydata#4340) Clarify drop_vars return value. (pydata#4244) Support explicitly setting a dimension order with to_dataframe() (pydata#4333) Increase support window of all dependencies (pydata#4296) Implement interp for interpolating between chunks of data (dask) (pydata#4155) Add @mathause to current core developers. (pydata#4335) install sphinx-autosummary-accessors from conda-forge (pydata#4332) Use sphinx-accessors-autosummary (pydata#4323) ndrolling fixes (pydata#4329) DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327) pin sphinx to 3.1(pydata#4326) nd-rolling (pydata#4219) Implicit dask import 4164 (pydata#4318) allow customizing the inline repr of a duck array (pydata#4248) silence the known docs CI issues (pydata#4316) enh: fixed pydata#4302 (pydata#4315) Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310) Fix map_blocks example (pydata#4305) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rst