bpo-35059: Cleanup usage of Python macros#10648
Merged
vstinner merged 1 commit intopython:masterfrom Nov 22, 2018
vstinner:cast_cleanup
Merged
bpo-35059: Cleanup usage of Python macros#10648vstinner merged 1 commit intopython:masterfrom vstinner:cast_cleanup
vstinner merged 1 commit intopython:masterfrom
vstinner:cast_cleanup
Conversation
Don't pass complex expressions but regular variables to Python macros. * _datetimemodule.c: split single large "if" into two "if" in date_new(), time_new() and datetime_new(). * _pickle.c, load_extension(): flatten complex "if" expression into more regular C code. * _ssl.c: addbool() now uses a temporary bool_obj to only evaluate the value once. * weakrefobject.c: replace "Py_INCREF(result = proxy);" with "result = proxy; Py_INCREF(result);"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't pass complex expressions but regular variables to Python
macros.
in date_new(), time_new() and datetime_new().
more regular C code.
the value once.
with "result = proxy; Py_INCREF(result);"
https://bugs.python.org/issue35059