Skip to content

bpo-42688: Fix ffi alloc/free when using external libffi on macos#23868

Merged
miss-islington merged 1 commit intopython:masterfrom
erykoff:issue42688
Dec 22, 2020
Merged

bpo-42688: Fix ffi alloc/free when using external libffi on macos#23868
miss-islington merged 1 commit intopython:masterfrom
erykoff:issue42688

Conversation

@erykoff
Copy link
Copy Markdown
Contributor

@erykoff erykoff commented Dec 20, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue42688

Automerge-Triggered-By: GH:ronaldoussoren

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Dec 20, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@erykoff

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

ronaldoussoren
ronaldoussoren approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington miss-islington merged commit b3c77ec into python:master Dec 22, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 22, 2020

Thanks @erykoff for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 22, 2020

GH-23888 is a backport of this pull request to the 3.9 branch.

ned-deily pushed a commit that referenced this pull request Feb 1, 2021
@miss-islington @erykoff
bpo-42688: Fix ffi alloc/free when using external libffi on macos (GH…
7e72997 
…-23868) (GH-23888)

Automerge-Triggered-By: GH:ronaldoussoren
(cherry picked from commit b3c77ec)

Co-authored-by: erykoff <erykoff@stanford.edu>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@erykoff @adorilson
bpo-42688: Fix ffi alloc/free when using external libffi on macos (py…
243aa8f 
…thonGH-23868)

Automerge-Triggered-By: GH:ronaldoussoren
@freakboy3742 freakboy3742 mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

+1 more reviewer

@hectorese1 hectorese1 hectorese1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erykoff @the-knights-who-say-ni @miss-islington @bedevere-bot @ronaldoussoren @hectorese1 @shihai1991