Add markdown.treeprocessors.UnescapeTreeprocessor#9671
Merged
AlexWaygood merged 1 commit intopython:mainfrom Feb 9, 2023
Merged
Add markdown.treeprocessors.UnescapeTreeprocessor#9671AlexWaygood merged 1 commit intopython:mainfrom
AlexWaygood merged 1 commit intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
andersk
force-pushed
the
markdown-unescape-treeprocessor
branch
2 times, most recently
from
9e0df55 to
fe0facb
Compare
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Feb 4, 2023
|
|
||
| class Treeprocessor(util.Processor): | ||
| def run(self, root) -> Any | None: ... | ||
| def run(self, root: Element) -> Element | None: ... |
Member
There was a problem hiding this comment.
The docstring refers to this method as taking an ElementTree object, and xml.etree.ElementTree.ElementTree is a different class to xml.etree.ElementTree.Element. Is the docstring incorrect?
Contributor
Author
There was a problem hiding this comment.
Good question, but yes, it’s really an Element, not an ElementTree: note this .getroot() call.
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
markdown-unescape-treeprocessor
branch
from
e1700aa to
36d63ae
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaced the deprecated
markdown.postprocessors.UnescapePostprocessorin Python-Markdown/markdown#1272.