fix(http): HttpHeaderParser improperly handled quoted parameter values#5897
Merged
bluestreak01 merged 4 commits intomasterfrom Jul 10, 2025
Merged
fix(http): HttpHeaderParser improperly handled quoted parameter values#5897bluestreak01 merged 4 commits intomasterfrom
bluestreak01 merged 4 commits intomasterfrom
Conversation
bluestreak01
approved these changes
Jul 10, 2025
Contributor
[PR Coverage check]😍 pass : 77 / 85 (90.59%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5757 by reworking the
HttpParserHeaderto be more compliant with the HTTP RFC when parsingContent-Type.When
HttpParserHeaderwas parsing theboundaryparameter it would just read every chars until the;delimiter, ignoring if the value was quoted.Users may now use any compliant HTTP clients and the server should be able to parse their requests and answer correctly to them.