fix(web-console): do not start a quote in comments#483
Merged
bluestreak01 merged 1 commit intomainfrom Oct 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the web console's SQL query parser where single quotes inside comments were incorrectly toggling the quote state, causing issues with query boundary detection.
- Fixed quote handling logic to ignore quotes when inside comments
- Added comprehensive test coverage for comments containing quotes and semicolons
- Enhanced test infrastructure to support custom localStorage configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-console/src/scenes/Editor/Monaco/utils.ts | Added condition to prevent quote state changes when inside comments |
| packages/browser-tests/cypress/integration/console/editor.spec.js | Added new test cases for quote handling in comments and updated test setup |
| packages/browser-tests/cypress/commands.js | Enhanced storage handling functions to support custom localStorage items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2e7f972 to
fab6752
Compare
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query extraction logic was problematic due to not ignoring single quotes inside a comment. It was taking
as a single query. This PR adds a check for comments when toggling the
inQuotevariable