Skip to content

fix: annotation e2e test instability by moving setup to project#9062

Merged
AdityaHegde merged 4 commits intomainfrom
fix/annotation-e2e-test-instability
Mar 19, 2026
Merged

fix: annotation e2e test instability by moving setup to project#9062
AdityaHegde merged 4 commits intomainfrom
fix/annotation-e2e-test-instability

Conversation

@AdityaHegde
Copy link
Copy Markdown
Collaborator

@AdityaHegde AdityaHegde commented Mar 16, 2026

I was seeing blank page without any error in logs. Not a 100% sure if this is fixes the issue, but moving the setup of annotations to the project works well and avoids waiting for reconciliation multiple times.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from ericpgreen2 March 17, 2026 12:07
@AdityaHegde AdityaHegde marked this pull request as ready for review March 17, 2026 12:07
Copy link
Copy Markdown
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

A few things to clean up before merge:

web-common/tests/projects/AdBidsAnnotations/ — committed tmp/ directory

The tmp/default/duckdb/*/meta.json files are runtime-generated cache artifacts (version timestamps, embedded SQL). Every other test project gitignores tmp/. These will be regenerated when the runtime starts on the copied project, so they're unnecessary — and if the model SQL ever drifts from the cached SQL in meta.json, you get silent staleness. Please remove tmp/ from the commit.

web-common/tests/projects/AdBidsAnnotations/ — missing .gitignore

This is how tmp/ got committed in the first place. Add a .gitignore matching AdBids/.gitignore:

.DS_Store

# Rill
.env
tmp
default
meta.db

web-common/tests/projects/AdBidsAnnotations/data/AdBids.csv.gz — consider a symlink

This is byte-for-byte identical to AdBids/data/AdBids.csv.gz (1.3 MB). Since cpSync with recursive: true follows symlinks, a relative symlink (../AdBids/data/AdBids.csv.gz) would avoid duplicating the blob in git history. Not a blocker, but worth the one-liner.

web-local/tests/explores/annotations.spec.ts:148 — stale comment

// Extra time for installAnnotations (file writes + reconciliation)installAnnotations no longer exists.

Note on naming: AdBidsAnnotations is consistent with the existing PascalCase majority (AdBids, AdImpressions), so no need to change it here. For future test projects, kebab-case (e.g., ad-bids-annotations) would be a more natural directory naming convention. Worth standardizing in a separate pass if the team agrees.


Developed in collaboration with Claude Code

@AdityaHegde AdityaHegde force-pushed the fix/annotation-e2e-test-instability branch from e92b12f to f21be29 Compare March 19, 2026 04:32
@AdityaHegde AdityaHegde merged commit 4c134d0 into main Mar 19, 2026
10 checks passed
@AdityaHegde AdityaHegde deleted the fix/annotation-e2e-test-instability branch March 19, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants