Skip to content

Refactor project lookup to return bool instead of sentinel error#9101

Merged
k-anshul merged 1 commit intomainfrom
begelundmuller/refactor-project-lookup-errors
Mar 24, 2026
Merged

Refactor project lookup to return bool instead of sentinel error#9101
k-anshul merged 1 commit intomainfrom
begelundmuller/refactor-project-lookup-errors

Conversation

@begelundmuller
Copy link
Copy Markdown
Contributor

@begelundmuller begelundmuller commented Mar 23, 2026

  • Fixes a place where the error got rewritten, leading to accidental Warning: failed to pull environment credentials: in rill validate
  • Changes ErrNoMatchingProject to ErrInferProjectFailed to make it less confusing (it's not clear to the user that inference is happening, so "matching" the previous error didn't accurately convey what went wrong)
  • Removes a reference to the cli package from the runtime

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Mar 23, 2026
@begelundmuller begelundmuller requested a review from k-anshul March 23, 2026 17:52
@k-anshul k-anshul merged commit 2480cb6 into main Mar 24, 2026
17 checks passed
@k-anshul k-anshul deleted the begelundmuller/refactor-project-lookup-errors branch March 24, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants