Skip to content

fix: download report crashing the app breaking download#9126

Merged
AdityaHegde merged 1 commit intomainfrom
fix/download-report-app-crash
Mar 26, 2026
Merged

fix: download report crashing the app breaking download#9126
AdityaHegde merged 1 commit intomainfrom
fix/download-report-app-crash

Conversation

@AdityaHegde
Copy link
Copy Markdown
Collaborator

In our recent orval refactor our API types got moved to Partial<RequestMessage>. But we call fromJson internally which means we need to pass json objects.

This is a hotfix for report downloads. We need to figure out a long term solution for the API types issues.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from ericpgreen2 March 26, 2026 13:59
@AdityaHegde AdityaHegde force-pushed the fix/download-report-app-crash branch from 456182d to 19ea66b Compare March 26, 2026 14:05
Copy link
Copy Markdown
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@AdityaHegde AdityaHegde merged commit d10b635 into main Mar 26, 2026
10 checks passed
@AdityaHegde AdityaHegde deleted the fix/download-report-app-crash branch March 26, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants