Skip to content

do case insensitive comparison of res name in security checks#9151

Merged
begelundmuller merged 1 commit intomainfrom
case_insensitive_sec_cond_check
Apr 1, 2026
Merged

do case insensitive comparison of res name in security checks#9151
begelundmuller merged 1 commit intomainfrom
case_insensitive_sec_cond_check

Conversation

@pjain1
Copy link
Copy Markdown
Member

@pjain1 pjain1 commented Mar 31, 2026

Since controller also stores the resource names in lower case.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@pjain1 pjain1 requested a review from begelundmuller March 31, 2026 13:28
Copy link
Copy Markdown
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begelundmuller begelundmuller merged commit 42903e9 into main Apr 1, 2026
16 checks passed
@begelundmuller begelundmuller deleted the case_insensitive_sec_cond_check branch April 1, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants