Skip to content

fix: avatar dropdown menu positioning and font weight#9153

Merged
ericpgreen2 merged 1 commit intomainfrom
ericgreen/fix-avatar-menu-positioning
Mar 31, 2026
Merged

fix: avatar dropdown menu positioning and font weight#9153
ericpgreen2 merged 1 commit intomainfrom
ericgreen/fix-avatar-menu-positioning

Conversation

@ericpgreen2
Copy link
Copy Markdown
Contributor

@ericpgreen2 ericpgreen2 commented Mar 31, 2026

  • Right-align avatar DropdownMenu.Content so it doesn't hug the viewport edge
  • Add font-normal text-inherit to DropdownMenuItem and DropdownMenuCheckboxItem wrappers to override the global a { font-medium } rule that made link items appear bolder than non-link items
  • Default DropdownMenuSubContent alignment to "start" so the first submenu item lines up with its trigger instead of centering vertically

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

- Right-align the avatar menu so it doesn't hug the viewport edge
- Override global `a { font-medium }` on menu item wrappers so link
  items match non-link items
- Default submenu alignment to "start" so the first child item aligns
  with its trigger rather than centering vertically
@ericpgreen2 ericpgreen2 requested a review from royendo March 31, 2026 16:27
@ericpgreen2 ericpgreen2 self-assigned this Mar 31, 2026
Copy link
Copy Markdown
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpgreen2 ericpgreen2 merged commit 40d2576 into main Mar 31, 2026
15 of 16 checks passed
@ericpgreen2 ericpgreen2 deleted the ericgreen/fix-avatar-menu-positioning branch March 31, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants