Conversation
| dark: | ||
| primary: "#818cf8" | ||
| secondary: "#a78bfa" | ||
| kpi-positive: "#4ade80" # Brighter green for dark mode |
There was a problem hiding this comment.
This example is relevant to the newly added kpi theme support. Was this removed by mistake?
There was a problem hiding this comment.
@djbarnwal This file is generated from the JSON schema in project.schema.yaml – notice the GENERATED. DO NOT EDIT at the top of this file.
It seems this snippet was added manually, which is why it got removed here when I ran make docs.generate.
There was a problem hiding this comment.
I have fixed this by adding the example in project.schema.yaml and re-generating the docs. In the future, note that the reference docs are generated from the JSON schema, so it's important to make changes in the JSON schema, not directly in the generated docs files :)
There was a problem hiding this comment.
Got it, I think this was added by product team directly through Cursor. Given how much of our codebase changes are agentic these days, would be good to add some docs or rules for the agent for guardrails.
There was a problem hiding this comment.
Got it, probably it's AI not reading the file headers. We could have a CI check that checks if re-generating files leads to changes. Will take a note for that.
This also removes references to the never-launched
vega_literenderer