Skip to content

Remove legacy canvas RPCs#9179

Merged
begelundmuller merged 2 commits intomainfrom
begelundmuller/remove-old-canvas-rpcs
Apr 3, 2026
Merged

Remove legacy canvas RPCs#9179
begelundmuller merged 2 commits intomainfrom
begelundmuller/remove-old-canvas-rpcs

Conversation

@begelundmuller
Copy link
Copy Markdown
Contributor

This also removes references to the never-launched vega_lite renderer

dark:
primary: "#818cf8"
secondary: "#a78bfa"
kpi-positive: "#4ade80" # Brighter green for dark mode
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is relevant to the newly added kpi theme support. Was this removed by mistake?

Copy link
Copy Markdown
Contributor Author

@begelundmuller begelundmuller Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djbarnwal This file is generated from the JSON schema in project.schema.yaml – notice the GENERATED. DO NOT EDIT at the top of this file.

It seems this snippet was added manually, which is why it got removed here when I ran make docs.generate.

Copy link
Copy Markdown
Contributor Author

@begelundmuller begelundmuller Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this by adding the example in project.schema.yaml and re-generating the docs. In the future, note that the reference docs are generated from the JSON schema, so it's important to make changes in the JSON schema, not directly in the generated docs files :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I think this was added by product team directly through Cursor. Given how much of our codebase changes are agentic these days, would be good to add some docs or rules for the agent for guardrails.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, probably it's AI not reading the file headers. We could have a CI check that checks if re-generating files leads to changes. Will take a note for that.

@begelundmuller begelundmuller merged commit 4fc98e8 into main Apr 3, 2026
16 of 18 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/remove-old-canvas-rpcs branch April 3, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants