fix some navigation issues in --preview mode back to /dashboards#9190
Merged
fix some navigation issues in --preview mode back to /dashboards#9190
Conversation
AdityaHegde
approved these changes
Apr 7, 2026
Collaborator
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Approving. The item about using file path should be addressed before merge. Rest can be follow up PRs.
| section: "project", | ||
| depth: -1, | ||
| href: "/", | ||
| href: mode === "Preview" ? "/dashboards" : "/", |
Collaborator
There was a problem hiding this comment.
Are we using constants like Preview? Would be good to move it to an enum instead. Can be a follow up PR though.
| importStep = step; | ||
| if (currentFilePath) { | ||
| currentFileRoute = `/files${addLeadingSlash(currentFilePath)}`; | ||
| if ($previewModeStore) { |
Collaborator
There was a problem hiding this comment.
Would be good to have a utility file for all the path switches based on mode. That way it is also testable. Lets do a follow up for this as well, would be good to add tests for these utlities.
web-common/src/features/add-data/manager/GenerateDashboardStatus.svelte
Outdated
Show resolved
Hide resolved
royendo
added a commit
that referenced
this pull request
Apr 7, 2026
* fix some navigation issues in --preview mode back to /dashboards * Update GenerateDashboardStatus.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSERT DESCRIPTION HERE
Checklist: