Skip to content

Convert chapters 15#3956

Merged
chriskrycho merged 2 commits intorust-lang:mainfrom
bzierk:ch12-ch15
Jun 14, 2024
Merged

Convert chapters 15#3956
chriskrycho merged 2 commits intorust-lang:mainfrom
bzierk:ch12-ch15

Conversation

@bzierk
Copy link
Copy Markdown
Contributor

@bzierk bzierk commented Jun 12, 2024 •
edited
Loading

Adds Listing conversion for chapter 12, 13, 14, and 15

@chriskrycho
Copy link
Copy Markdown
Contributor

chriskrycho commented Jun 13, 2024

Thanks! Note that there are real CI failures due to some missed opening/closing tags, etc., so once you address that, I'll be happy to review it and get it landed!

@bzierk bzierk changed the title Convert chapters 12-15 Convert chapters 15 Jun 14, 2024
@bzierk
Copy link
Copy Markdown
Contributor Author

bzierk commented Jun 14, 2024 •
edited
Loading

The opening/closing tags is a bad error, I've found. This is the result of the < characters causing parsing Token::Attribute to fail. It seems like the error doesn't actually get propagated up but the <Listing> never gets created after that error so mdbook thinks its a missing tags issue. I opened another PR to get 12-14 in and I'll keep working on the issue with xmlparser and <.

@asggWa

This comment was marked as off-topic.

Sign in to view
@chriskrycho
Copy link
Copy Markdown
Contributor

chriskrycho commented Jun 14, 2024

Ah, that makes sense (per your comment on the tracking issue) @bzierk – thanks!

@chriskrycho chriskrycho merged commit 3216c0f into rust-lang:main Jun 14, 2024
chriskrycho added a commit that referenced this pull request Oct 15, 2024
@chriskrycho @bzierk
Use <Listing> for Chapter 15
d8a10b8 
This restores the work originally done in #3956, which had to be dropped
from that PR because this chapter was blocked on XML handling, which was
resolved in #3975.

Co-authored-by: Bryan Zierk <bryan.zierk@gmail.com>
@chriskrycho chriskrycho mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bzierk @chriskrycho @asggWa