Ayu theme doesn't work

[Nemo157]

Go to a recently published crate like https://docs.rs/streaming_algorithms/0.3.0/streaming_algorithms/, and try to switch to ayu theme, the page loses all styling information because the ayu css is 404. I'm guessing we don't pull it in as part of the "per-nightly" files.

cc @Cldfire

[Nemo157]

Specifically missing from

docs.rs/src/docbuilder/rustwide_builder.rs

Lines 36 to 52 in 731d031

	const ESSENTIAL_FILES_VERSIONED: &[&str] = &[
	"brush.svg",
	"wheel.svg",
	"down-arrow.svg",
	"dark.css",
	"light.css",
	"main.js",
	"normalize.css",
	"rustdoc.css",
	"settings.css",
	"settings.js",
	"storage.js",
	"theme.js",
	"source-script.js",
	"noscript.css",
	"rust-logo.png",
	];

but, I think adding it here might make building with older nightlies fail, if that's an issue we may need some kind of "optional files" as well?

[Cldfire]

Interesting, thanks for noticing that!

Is failing to build with older nightlies a problem? I was under the assumption that docs.rs would only upgrade nightly versions as time went on. Do builds get downgraded sometimes as well?

[emilyalbini]

but, I think adding it here might make building with older nightlies fail, if that's an issue we may need some kind of "optional files" as well?

I don't care much about older nightlies tbh.

[jyn514]

Yes, the nightly version is sometimes locked to an older one if a release has bugs. See for example #832. It needs to be possible to build with a nightly that does not yet have the Ayu theme (at least for the next 4 months or so until it hits stable).

[jyn514]

I don't care much about older nightlies tbh.

I guess we only need one nightly of buffer. So since there are several nightlys with Ayu now we can just require it's always there.

[Cldfire]

Ah that makes sense. So it sounds like we should wait a couple of days and then go ahead and add ayu.css to the list of files there.

[jyn514]

Marking as P-high since this looks really bad. Marking as E-medium because testing this requires doing a full build locally.

[jyn514]

I tried adding ayu.css but it didn't help. Not sure why.