Add favicon to essential files#1109
Merged
jyn514 merged 1 commit intorust-lang:masterfrom Oct 22, 2020
Merged
Conversation
This can be tested with `cargo run build add-essential-files && cargo build chrono 0.4.18`.
Contributor
|
So when I was working on the static files I realised that the per-version favicon.ico is redirected to our favicon.ico, should we do the same and add a static favicon.svg that we redirect to? |
Nemo157
approved these changes
Oct 22, 2020
Member
Author
|
From our conversation on discord:
It might be nice long term to look into de-duplicating files in general, which I imagine would have enormous storage cost reductions, but sounds hard to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be tested with
cargo run build add-essential-files && cargo build chrono 0.4.18.Closes #1070.
r? @Nemo157