Skip to content

Make HashSet::insert return OccupiedEntry#495

Merged
bors merged 1 commit intorust-lang:masterfrom
SUPERCILEX:insert
Feb 18, 2024
Merged

Make HashSet::insert return OccupiedEntry#495
bors merged 1 commit intorust-lang:masterfrom
SUPERCILEX:insert

Conversation

@SUPERCILEX
Copy link
Copy Markdown
Contributor

@SUPERCILEX SUPERCILEX commented Feb 2, 2024

@SUPERCILEX SUPERCILEX mentioned this pull request Feb 2, 2024
Merged
@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 12, 2024

☔ The latest upstream changes (presumably #502) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Feb 16, 2024

Sorry for the late review, can you rebase to fix conflicts?

@SUPERCILEX
Make HashSet::insert return OccupiedEntry
9beb0d2 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Copy Markdown
Contributor Author

SUPERCILEX commented Feb 16, 2024

Sure, done.

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Feb 18, 2024

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 18, 2024

📌 Commit 9beb0d2 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 18, 2024

⌛ Testing commit 9beb0d2 with merge 274c7bb...

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 18, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 274c7bb to master...

@bors bors merged commit 274c7bb into rust-lang:master Feb 18, 2024
@decathorpe
Copy link
Copy Markdown

decathorpe commented Mar 19, 2024

Reading this comment:
rust-lang/rust#120077 (comment)

And the changes (i.e. the signature of the insert function has changed), shouldn't this have been released as v0.15.0 instead of v0.14.4? Or is changing the return type of a function from () to non-() OK?

cuviper
cuviper reviewed Mar 19, 2024
View reviewed changes
src/set.rs
/// Vacant(single_entry) => {
/// // We found a new character for the first time.
/// single_entry.insert()
/// single_entry.insert();
Copy link
Copy Markdown
Member

@cuviper cuviper Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exemplifies how it was a breaking change to return something other than ().

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Mar 20, 2024

I've yanked the release.

@SUPERCILEX
Copy link
Copy Markdown
Contributor Author

SUPERCILEX commented Mar 25, 2024

Will there be a replacement release for the stdlib?

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Mar 29, 2024

Yes, I'll prepare a new release next week. I've been busy at Rust Nation this week.

@SUPERCILEX
Copy link
Copy Markdown
Contributor Author

SUPERCILEX commented Mar 29, 2024

Oh fun! Sounds good.

@Amanieu Amanieu mentioned this pull request Apr 28, 2024
Merged
bors added a commit that referenced this pull request Apr 28, 2024
@bors
Auto merge of #521 - Amanieu:release-0.14.5, r=Amanieu
250040a 
Release 0.14.5

This temporarily reverts (#495) since that is a breaking change that will be included in v0.15.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuviper cuviper cuviper left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SUPERCILEX @bors @Amanieu @decathorpe @cuviper