Merged
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
sfackler
force-pushed
the
sem
branch
10 times, most recently
from
3ebc3f7 to
36b317f
Compare
Member
Author
|
Builds pass |
src/unix/notbsd/android/mod.rs
Outdated
| } | ||
|
|
||
| pub struct sem_t { | ||
| pub count: ::c_uint, |
Member
There was a problem hiding this comment.
Perhaps this could be opaque like the other platforms? That'd mean the special case in build.rs could be removed as well
Member
There was a problem hiding this comment.
(also applicable with musl below)
Member
|
Nice! All looks good to me, just a minor nit about making the fields private (to avoid some extra libc-test logic), but other than that r=me |
Member
Author
|
Updated |
Member
Contributor
Contributor
|
☀️ Test successful - status-appveyor, travis |
bors
added a commit
that referenced
this pull request
Jun 10, 2016
Fix semaphores on Solaris/Illumos This adds `sem_t` structure introduced in #309 and fixes compilation on Solaris.
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Update signalfd Update `signalfd` to use types and functions from `libc`. It is a breaking change, because: - renamed pub const `CREATE_NEW_FD` to `SIGNALFD_NEW` - renamed pub const `SIGINFO_SIZE` to `SIGNALFD_SIGINFO_SIZE` - removed pub const `SIGINFO_PADDING` Fixes rust-lang#307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.