-
Notifications
You must be signed in to change notification settings - Fork 465
Check that offset is not too big, check projection offset to be inbounds #447
Copy link
Copy link
Closed
rust-lang/rust
#63075Labels
A-validationArea: This affects enforcing the validity invariant, and related UB checkingArea: This affects enforcing the validity invariant, and related UB checkingC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementI-misses-UBImpact: makes Miri miss UB, i.e., a false negative (with default settings)Impact: makes Miri miss UB, i.e., a false negative (with default settings)
Metadata
Metadata
Assignees
Labels
A-validationArea: This affects enforcing the validity invariant, and related UB checkingArea: This affects enforcing the validity invariant, and related UB checkingC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementI-misses-UBImpact: makes Miri miss UB, i.e., a false negative (with default settings)Impact: makes Miri miss UB, i.e., a false negative (with default settings)
Type
Fields
Give feedbackNo fields configured for issues without a type.
According to rust-lang/rust#53676, there is an upper bound to what you can do with
offset. miri should check that.Related question: Shouldn't the
place_fieldmethod in the miri engine checkpointer_offset_inbounds? That will be a heavy perf hit, but I think we might currently be missing out on some UB.