You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before we link bindgen with default features including runtime libclang.
After the pr, we can build bindgen-cli with no-defautl-features to link static libclang, such as 'cargo install --locked --no-default-features -F static,logging --path .'
If not , runtime and static feature will be confict reported by the clang-sys.
Look like the repo did not have a ci? I just test this with change:"bindgen = { path = "../bindgen", version = "=0.65.1", default-features = false, features = ["logging", "which-rustfmt", "__cli", "experimental"] }".
And the pr using the change "bindgen = { path = "../bindgen", version = "=0.65.1", default-features = false, features = [ "__cli", "experimental"] }" which did not have feature:logging and which-rustfmt did not test
yeah I think this was an oversight when we migrated bindgen to workspaces as we use the dynamic library for clang by default, so unless you've been trying to install bindgen-cli with static support by explicitly passing --features=static it is unlikely that you've noticed this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we link bindgen with default features including runtime libclang.
After the pr, we can build bindgen-cli with no-defautl-features to link static libclang, such as 'cargo install --locked --no-default-features -F static,logging --path .'
If not , runtime and static feature will be confict reported by the clang-sys.