check f16 and f128 in float_equality_without_abs#15054
Merged
llogiq merged 1 commit intorust-lang:masterfrom Aug 24, 2025
Merged
check f16 and f128 in float_equality_without_abs#15054llogiq merged 1 commit intorust-lang:masterfrom
llogiq merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
y21
reviewed
Jun 14, 2025
Member
|
Can you also add tests for this? It seems like there's also a f16_f128 FIXME in the code that could easily be resolved in the same PR here: |
Contributor
Author
Added. |
llogiq
reviewed
Aug 23, 2025
Contributor
llogiq
left a comment
There was a problem hiding this comment.
Apart from the needless query overhead this looks good. Please fix this small nit. And sorry for the delay.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup of rust-lang/rust#141874
cc rust-lang/rust#116909
changelog: check f16 and f128 in float_equality_without_abs