-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
//@ needs-matching-clang is misleading #126180
Copy link
Copy link
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Description
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Via #126155, I discovered that the
//@ needs-matching-clangcompiletest header is a lot more strict than one might assume from its name.Tests with this header are not run by default, regardless of whether a “matching clang” is available or not. Instead, they only run if environment variable
RUSTBUILD_FORCE_CLANG_BASED_TESTSis set.The only test job that sets this variable is
x86_64-gnu-debug, but that job currently doesn't actually run any tests! (Though that might change as a result of #126155.)@rustbot label +A-compiletest +A-testsuite