-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Documentation of default value for config.toml's rust.channel is inaccurate #128258
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Metadata
Metadata
Assignees
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for issues without a type.
On current master:
rust/config.example.toml
Lines 578 to 581 in 7c2012d
Same thing on the 1.80.0 release tag: https://github.com/rust-lang/rust/blob/1.80.0/config.example.toml#L582
This default value of "dev" used to be accurate prior to #125181, i.e. with Rust 1.79 and older. The default value comes from this hardcoded value: https://github.com/rust-lang/rust/blob/1.79.0/src/bootstrap/src/core/config/config.rs#L1179.
But post-#125181, the default value varies by how you got your source tarball, or what git branch you are on. It is not accurate for the Rust 1.80.0 release sources to say the default value for
rust.channelis "dev", as it's actually "stable" now.Mentioning @onur-ozkan @clubby789 since you worked on the PR (which I am otherwise happy with).
The change in default also needs to be called out in src/bootstrap/src/utils/change_tracker.rs.