Test failed in issue-101082.rs: expected string not found in input

[DKLoehr]

We've started seeing this test failure when trying to package rust for use in chromium (link to build output). The output says

--- stderr -------------------------------
 C:\b\s\w\ir\cache\builder\src\third_party\rust-src\tests\codegen\issues\issue-101082.rs:30:16: error: x86-64-v3: expected string not found in input
  // x86-64-v3: masked.load
...

I see the comment in issue-101082.rs mentions that the test got changed until llvm/llvm-project#134513 got fixed upstream, which happened a few hours ago. Perhaps we need to change the test back now?

[jieyouxu]

cc @cuviper

[cuviper]

cc #139430 @scottmcm

Perhaps we need to change the test back now?

We can, but only for sufficiently new LLVM -- I guess you're keeping up with LLVM main?

[DKLoehr]

Yes, we use the most recent version of both.

[durin42]

We're also seeing this in our build of LLVM/Rust@HEADs - since the test is already using revisions the easiest thing would be to fork the test into an llvm 20 and an llvm 21+ flavor, but I could also probably make it work by having an x86-64-v3-20 and an x86-64-v3 revision since that seems to be the only difference.

@cuviper would you like me to try one of those?

[cuviper]

I think you can just convert the x86-64-v3 part into min-llvm-version: 21 and forget about the masked.load check. That was mostly just so we would notice that it changed (#139430 (comment)), and here we are with the fix! :)