-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Remaining issues after the #[doc] attribute port #149865
Copy link
Copy link
Open
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`)Area: Attributes (`#[…]`, `#![…]`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`)Area: Attributes (`#[…]`, `#![…]`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
From #149645
cfg_old.rsare likely unused now, so they should be removed. Remove unused code incfg_old#149903doc(test(attr(...)))is handled in a horrifying manner currently. Until we can handle it correctly with theAttributesystem, it'll remain that thing we're all very ashamed of. 😈Docare suboptimal, likeinlinewhich instead of being anOptionis aThinVecbecause we report the error later on. Part of the things I'm not super happy about but can be postponed to future me.src/librustdoc/clean/cfg.rs, thepub(crate) fn parse(cfg: &MetaItemInner) -> Result<Cfg, InvalidCfgError> {function should be removed oncecfg_tracehas been ported to newcfgAPI. [DON'T MERGE] Port#[cfg]and#[cfg_attr]trace attributes to the new attribute parsers #150092DocFragmentwent from 32 to 48. Would be nice to get it back to 32.malformed `doc` attribute inputwasn't meant for so many candidates, should be improved. If there are too many suggestions for malformed attribute, do not suggest them #149917check_attrwe can move to attribute parsingdoc(alias)on fields & patternsInvalidTargetinstead ofAttributeLintKind::AttrCrateLevelOnlyandDocAttrNotCrateLevel