-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Local rustc-docs could make use of local pages for std types #151496
Copy link
Copy link
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Posting this for @blyxyas and big thanks for having spotted this issue real quick :)
Location (URL)
The same problem persists in many different pages, just to pick an example on my machine:
$RUSTUP_HOME/toolchains/nightly-aarch64-apple-darwin/share/doc/rust/html/rustc-docs/rustc_trait_selection/errors/struct.AmbiguousImpl.htmlSummary
The external link for
Option<>ishttps://doc.rust-lang.org/nightly/core/option/enum.Option.html, which is probably desirable for online usage, but considering the fact that this download is intended for offline usage, it'd be better if it can point to thestddocs just next to it, i.e.$RUSTUP_HOME/toolchains/nightly-aarch64-apple-darwin/share/doc/rust/html/std/option/enum.Option.html?A few things to be noted for this issue:
This issue should be resolved in a way that it doesn't break the online docs.
This does imply an implicit dependency between
rustc-docsandrust-docswhichrustupis not quite ready to handle, but sincerustc-docsis mostly for in-house usage, I believe we can focus on redirecting the links for the time being.cc @GuillaumeGomez @jieyouxu