-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
mGCA: Support directly represented negated literals #152123
Copy link
Copy link
Closed
Labels
A-AST-loweringArea: AST lowering (AST → HIR)Area: AST lowering (AST → HIR)A-const-genericsArea: const generics (parameters and arguments)Area: const generics (parameters and arguments)E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.F-adt_const_params`#![feature(adt_const_params)]``#![feature(adt_const_params)]`F-min_generic_const_args`#![feature(min_generic_const_args)]``#![feature(min_generic_const_args)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-AST-loweringArea: AST lowering (AST → HIR)Area: AST lowering (AST → HIR)A-const-genericsArea: const generics (parameters and arguments)Area: const generics (parameters and arguments)E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.F-adt_const_params`#![feature(adt_const_params)]``#![feature(adt_const_params)]`F-min_generic_const_args`#![feature(min_generic_const_args)]``#![feature(min_generic_const_args)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Follow up of #150618 and #150699. We currently support directly represented literals as a
hir::ConstArgKind::Literalbut we don't support negated literals as such a representation:Not certain of the right way of implementing this, maybe extending
ConstArgKind::Literalwith a flag for whether it was negated or not 🤔 Then it should just be a matter of updatinglower_anon_const_to_const_arg_directwith a case for-1as well as threading the bool into the input oflit_to_constinlower_const_arg_literalOnce this and #152001 have been done we should remove the special casing in parsing under mGCA for literals being parsed as anon consts instead of direct const args.