E0088 needs to be updated to new format

[sophiajt]

From: src/test/compile-fail/E0088.rs

Error E0088 needs to be updated with a span_label, taking it from:

error[E0088]: too many lifetime parameters provided: expected 0 parameters, found 1 parameter
  --> src/test/compile-fail/E0088.rs:14:9
   |
14 |     f::<'static>(); //~ ERROR E0088
   |         ^^^^^^^

To:

error[E0088]: too many lifetime parameters provided: expected 0 parameters, found 1 parameter
  --> src/test/compile-fail/E0088.rs:14:9
   |
14 |     f::<'static>(); //~ ERROR E0088
   |         ^^^^^^^ 0 lifetime parameters expected

Bonus: we may want to detect the 0 case and say:

error[E0088]: too many lifetime parameters provided: expected 0 parameters, found 1 parameter
  --> src/test/compile-fail/E0088.rs:14:9
   |
14 |     f::<'static>(); //~ ERROR E0088
   |         ^^^^^^^ unexpected lifetime parameter

[bstrie]

Freeing this one up as part of the final push for #35233. @yossi-k , it looks like you already have an in-flight PR which now should be unblocked thanks to @jonathandturner 's recent PR, so feel free to reclaim this if you have time. Otherwise, anyone else may want to base their work off of @yossi-k 's PR.

[ojsheikh]

I can finish this up based on @yossi-k's PR. Based on the discussion for #36208, it seems all that is required (aside from a rebase/cherry-pick) is to change the target span to be that of the first unexpected lifetime argument, instead of attempting to merge the spans. However, since functions do not take lifetime parameters at all that will always turn out to be the first lifetime parameter supplied to the function call. As such, will it be better if the error message specified that function calls never take lifetime parameters at all?