E0449 needs to be updated to new format

[sophiajt]

From: src/test/compile-fail/E0449.rs

E0449 needs a span_label and a span_note changed to a note, updating this:

error[E0449]: unnecessary visibility qualifier
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^^^^^^^^^^^^^
   |
note: place qualifiers on individual impl items instead
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^^^^^^^^^^^^^

To:

error[E0449]: unnecessary visibility qualifier
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^^^^^^^^^^^^^ `pub` not needed here
   |
   = note: place qualifiers on individual impl items instead

Bonus (though not sure if this is reasonable, but would be nice to try): let's underline the pub if we can.

error[E0449]: unnecessary visibility qualifier
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^ `pub` not needed here
   |
   = note: place qualifiers on individual impl items instead

[alexispurslane]

I'm working on fixing this.

[sophiajt]

Ha, you beat me to it @ChristopherDumas

I was going to say that @nightlark signed up on the big list though at this point, since that list has been around so long, I'm starting to think we should do a free-for-all.

[nightlark]

I've been trying to use the bootstrap.py build system @jonathandturner, but the only way I've been able to get it to work is by getting rid of everything that has been compiled each time (basically getting a fresh copy of the repository each time, which takes a few hours to build). Are any changes needed to the arguments passed to bootstrap.py in order to get it to work? I'm using a Mac, and it looks like all of the minimum versions are met with respect to dependencies for compiling from source.

$ python src/bootstrap/bootstrap.py --step libstd --stage 1
Finished debug [unoptimized + debuginfo] target(s) in 0.0 secs
Synchronizing submodule url for 'src/compiler-rt'
Synchronizing submodule url for 'src/jemalloc'
Synchronizing submodule url for 'src/liblibc'
Synchronizing submodule url for 'src/llvm'
Synchronizing submodule url for 'src/rt/hoedown'
Synchronizing submodule url for 'src/rust-installer'
Unknown option: -C
usage: git [--version] [--help] [-c name=value]
[--exec-path[=]] [--html-path] [--man-path] [--info-path]
[-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
[--git-dir=] [--work-tree=] [--namespace=]
[]
command did not execute successfully: "git" "-C" "src/compiler-rt" "reset" "--hard"
expected success, got: exit code: 129

[sophiajt]

@nightlark - that's strange. What version of git are you running?

This is what's on my mac:

$ git --version
git version 2.9.2

[sophiajt]

@nightlark - working on a fix now: #36456

[nightlark]

@jonathandturner - I'm running version 1.8.4; thanks for the fix, I'll try it out. (And update if it still doesn't work).

[nightlark]

@ChristopherDumas did you already do this, or I can I still send my PR in?

[alexispurslane]

No, I haven't done this. high school started and I forgot. Go ahead.

[bstrie]

Freeing this one up as part of the final push for #35233.