target tuples for solaris not quite right

[binarycrusader]

There are actually two different generally expected encodings of the host tuple and they're subtly different than what some might expect.

For example, 'x86_64-sun-solaris' should probably be x86_64-pc-solaris. The reason for that is that the encoding schemes are actually:

#    CPU_TYPE-MANUFACTURER-OPERATING_SYSTEM
...
#    CPU_TYPE-MANUFACTURER-KERNEL-OPERATING_SYSTEM

https://github.com/gcc-mirror/gcc/blob/master/config.sub

So while 'sparcv9-sun-solaris' is correct because Sun is the (historical) manufacturer of sparc CPUs, 'x86_64-sun-solaris' is not, because the MANUFACTURER here is the manufacturer of the CPU not the operating system. There are special cases for this, for example 'x86_64-apple-darwin', even though Apple doesn't make x86_64 CPUs, but following gcc/clang conventions leads us to x86_64-pc-solaris.

This issue has been assigned to @lzutao via this comment.

[binarycrusader]

/cc @dhduvall
/cc @ebeasant

[Mark-Simulacrum]

An interesting discrepancy here is that our target and the LLVM target currently don't match. I'm not sure whether we can/should change anything here for backwards compatibility reasons, though an alias seems fine.

$ rg 'x86_64-.*-solaris'
src/librustc_back/target/mod.rs
204:    ("x86_64-sun-solaris", x86_64_sun_solaris),

src/librustc_back/target/x86_64_sun_solaris.rs
21:        llvm_target: "x86_64-pc-solaris".to_string(),

Hi, can I take this issue up? Can someone give a hint on how to fix this?

I am a rust beginner, interested in compilers. This would be my first contribution.

[varkor]

@Guruhegde: as far as I can tell, you should just be able to add a new line under:

rust/src/tools/build-manifest/src/main.rs

Line 120 in 597f432

"x86_64-sun-solaris",

containing "x86_64-pc-solaris",, and then add a new line under:

rust/src/librustc_target/spec/mod.rs

Line 432 in 597f432

("x86_64-sun-solaris", x86_64_sun_solaris),

containing:

// `x86_64-pc-solaris` is an alias for `x86_64_sun_solaris` for backwards compatibility reasons.
// (See https://github.com/rust-lang/rust/issues/40531.)
("x86_64-pc-solaris", x86_64_sun_solaris),

(Sorry for the delay: I only just saw your message.)

[tesuji]

@rustbot claim