-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
incremental: refactor out non-query data from tcx #44137
Copy link
Copy link
Closed
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
There are various fields in the tcx of data that is not tracked for incremental compilation, or is tracked in an odd way. Here is a
partiallist:trait_mapof TyCtxt private #44162trait_mapof TyCtxt private #44162specialization_cachein favor of a query #44157used_unsafefield on TyCtxt #44195In each case, the idea would be to (at least to start) encapsulate the fields so that we are using queries to access those maps. I'll try to write up some mentoring instructions for each one later on.
cc @michaelwoerister