-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Confusing docs: Command::output claims to "capture" stdin #44929
Copy link
Copy link
Closed
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.P-mediumMedium priorityMedium priority
Metadata
Metadata
Assignees
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.P-mediumMedium priorityMedium priority
Type
Fields
Give feedbackNo fields configured for issues without a type.
"capture" makes it sound like the data is stored somewhere for later inspection. There is no
stdinfield in process::Output.I did some looking into the implementation, and to me it seems that the child's stdin is simply closed before waiting. @talchas on IRC told me that it's made to be
Stdio::null().In any case, this should be clarified.
cc @steveklabnik