run-make-fulldeps/c-link-to-rust-va-list-fn fails on aarch64-linux-gnu

[parched]

Running python2.7 ./x.py test --stage 2 on aarch64-linux-gnu I end up with the following failure

---- [run-make] run-make-fulldeps/c-link-to-rust-va-list-fn stdou
t ----                                                           
                                                                 
error: make failed                                               
status: exit code: 2                                             
command: "make"                                                  
stdout:                                                          
------------------------------------------                       
LD_LIBRARY_PATH="/usr/src/myapp/build/aarch64-unknown-linux-gnu/t
est/run-make-fulldeps/c-link-to-rust-va-list-fn/c-link-to-rust-va
-list-fn:/usr/src/myapp/build/aarch64-unknown-linux-gnu/stage2/li
b:/usr/src/myapp/build/aarch64-unknown-linux-gnu/stage0-bootstrap
-tools/aarch64-unknown-linux-gnu/release/deps:/usr/src/myapp/buil
d/aarch64-unknown-linux-gnu/stage0/lib:" '/usr/src/myapp/build/aa
rch64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /usr/src/myap
p/build/aarch64-unknown-linux-gnu/test/run-make-fulldeps/c-link-t
o-rust-va-list-fn/c-link-to-rust-va-list-fn -L /usr/src/myapp/bui
ld/aarch64-unknown-linux-gnu/test/run-make-fulldeps/c-link-to-rus
t-va-list-fn/c-link-to-rust-va-list-fn  checkrust.rs             
cc -ffunction-sections -fdata-sections -fPIC test.c /usr/src/myap
p/build/aarch64-unknown-linux-gnu/test/run-make-fulldeps/c-link-t
o-rust-va-list-fn/c-link-to-rust-va-list-fn/libcheckrust.a -o /us
r/src/myapp/build/aarch64-unknown-linux-gnu/test/run-make-fulldep
s/c-link-to-rust-va-list-fn/c-link-to-rust-va-list-fn/test -lm -l
rt -ldl -lpthread 
LD_LIBRARY_PATH="/usr/src/myapp/build/aarch64-unknown-linux-gnu/t
est/run-make-fulldeps/c-link-to-rust-va-list-fn/c-link-to-rust-va
-list-fn:/usr/src/myapp/build/aarch64-unknown-linux-gnu/stage2/li
b/rustlib/aarch64-unknown-linux-gnu/lib:/usr/src/myapp/build/aarc
h64-unknown-linux-gnu/stage0-bootstrap-tools/aarch64-unknown-linu
x-gnu/release/deps:/usr/src/myapp/build/aarch64-unknown-linux-gnu
/stage0/lib:" /usr/src/myapp/build/aarch64-unknown-linux-gnu/test
/run-make-fulldeps/c-link-to-rust-va-list-fn/c-link-to-rust-va-li
st-fn/test                                                       
Makefile:4: recipe for target 'all' failed                       
                                                                 
------------------------------------------                       
stderr:                                                          
------------------------------------------                       
test: test.c:32: main: Assertion `test_rust(check_list_0, 0x01LL,
 0x02, 0x03LL) == 0' failed.                                     
Aborted (core dumped)                                            
make: *** [all] Error 134                                        
                                                                 
------------------------------------------

I was building this commit 9cd3bef

I haven't had the chance to debug it yet but I'll take a look when I get a chance.

cc @dlrobertson

[dlrobertson]

We rely on the LLVM implementation of va_arg for Aarch64 (unlike clang). I bet we'll have to manually implement it like we do for i686.

[dlrobertson]

BTW thanks for testing and reporting this!