Recursive macro call inside concat macro fails to find macros referred to by $crate

[cwfitzgerald]

#[macro_export]
macro_rules! separator {
    () => { "/" };
}

#[macro_export]
macro_rules! concat_separator {
    ( $e:literal, $($other:literal),+ ) => {
        concat!($e, $crate::separator!(), $crate::concat_separator!($($other),+))
    };
    ( $e:literal ) => {
        $e
    }
}

fn main() {
    println!("{}", concat_separator!(2, 3, 4))
}

(Playground)

Errors:

   Compiling playground v0.0.1 (/playground)
error[E0433]: failed to resolve: could not find `separator` in `$crate`
  --> src/main.rs:9:29
   |
9  |         concat!($e, $crate::separator!(), $crate::concat_separator!($($other),+))
   |                             ^^^^^^^^^ could not find `separator` in `$crate`
...
17 |     println!("{}", concat_separator!(2, 3, 4))
   |                    -------------------------- in this macro invocation

error[E0433]: failed to resolve: could not find `concat_separator` in `$crate`
  --> src/main.rs:9:51
   |
9  |         concat!($e, $crate::separator!(), $crate::concat_separator!($($other),+))
   |                                                   ^^^^^^^^^^^^^^^^ could not find `concat_separator` in `$crate`
...
17 |     println!("{}", concat_separator!(2, 3, 4))
   |                    -------------------------- in this macro invocation

If either the recursion (playground) or the concat! is removed (playground), this compiles exactly as expected. Additionally, if I explicitly name my crate, it works as expected, but would be vulnerable to crate renames in user code (can't reproduce in playground because it doesn't build a library).

[nrc]

If you try and build Rustup, you get a similar failure, but without recursion or $crate. Seems that just using another macro and concat is enough in some circumstances

[tesuji]

cc @petrochenkov for the hygiene macro in #63535

[tesuji]

This code (playpen) compiles on stable but not on nightly and beta:

mod outer {
    macro_rules! foo {
        () => {
            "foo"
        };
    }

    macro_rules! bar {
        () => {
            concat!(foo!(), "bar")
        };
    }

    pub fn baz() {
        format!(bar!());
    }
}

[petrochenkov]

@lzutao
Please, file a separate issue for the regression, I'll prioritize it over pre-existing issues (which the original issue seems to be).

[tesuji]

Thanks, I filed it in #63685

[petrochenkov]

Fixed in #63717.

[cwfitzgerald]

Thanks for your work on this!